Skip to content
This repository has been archived by the owner on May 24, 2022. It is now read-only.

Make it a taskbar app (as originally thought) #312

Closed
Tbaut opened this issue Dec 19, 2018 · 4 comments
Closed

Make it a taskbar app (as originally thought) #312

Tbaut opened this issue Dec 19, 2018 · 4 comments

Comments

@Tbaut
Copy link
Collaborator

Tbaut commented Dec 19, 2018

Talking with @bjornwgnr about it.
We ditched the idea to make Fether a task bar/tray app at some point because it wasn't looking good on linux and windows (can't find the issue). I think we should spend some time on it again. It would potentially allow a much higher adoption because it can be launched on startup and sync comfortably while always be at hand (synced) to be used when needed... The inherent problems of using a light client are invisible because regularly synced in background.

@Tbaut Tbaut added this to the 0.3-beta Mainnet milestone Dec 19, 2018
@Tbaut Tbaut changed the title Make it from a tray icon (as originaly thought) Make it a taskbar app (as originaly thought) Dec 19, 2018
@amaury1093
Copy link
Collaborator

amaury1093 commented Dec 20, 2018

The relevant library: https://github.com/maxogden/menubar

Unforunately it doesn't seem so active anymore. Maybe there are others?

@Tbaut Tbaut changed the title Make it a taskbar app (as originaly thought) Make it a taskbar app (as originally thought) Dec 20, 2018
@ltfschoen
Copy link
Contributor

ltfschoen commented Jan 4, 2019

@amaurymartiny @Tbaut I had a go at this in branch https://github.com/paritytech/fether/compare/luke-312-taskbar-app?expand=1

screen shot 2019-01-04 at 1 46 46 pm

If I click the icon to show the taskbar app, and then go to View > Toggle Developer Tools, it displays:
screen shot 2019-01-04 at 1 50 34 pm

I think this is because previously in the fether-electron package's package.json the electron binary was called with "electron": "cross-env SKIP_PREFLIGHT_CHECK=true electron dist/main/main.js",, but now i it's called with "electron": "cross-env SKIP_PREFLIGHT_CHECK=true electron mb.js", and mb.js doesn't start a parity-ethereum node to expose that WebSocket port.

So I started a parity-ethereum node with the following, but it doesn't trust the origin from Blocked connection to WebSockets server from untrusted origin: Some("file://"):

scon @ ~/code/src/paritytech/parity-ethereum - [stable] $ ./target/release/parity --chain kovan --light
2019-01-04 13:47:59  Starting Parity-Ethereum/v2.1.9-stable-af1169d2f-20181205/x86_64-macos/rustc1.30.1
2019-01-04 13:47:59  Keys path /Users/scon/Library/Application Support/io.parity.ethereum/keys/kovan
2019-01-04 13:47:59  DB path /Users/scon/Library/Application Support/io.parity.ethereum/chains_light/kovan/db/9bf388941c25ea98
2019-01-04 13:47:59  Running in experimental Light Client mode.
2019-01-04 13:48:00  Debug API is not available in light client mode.
2019-01-04 13:48:00  Debug API is not available in light client mode.
2019-01-04 13:48:04  Public node URL: enode://25d97eab21b251a819a21cf914ded0493786fa4bc12c5906c455b2a7060d4d00a03c669286ce504438bdecb39942f2dc6e431231d0b53fc9655cc776b12f69cd@172.20.10.4:30303
2019-01-04 13:48:05  Syncing #9938926 0xbcff…74c9     0.0 hdr/s      0+    0 Qed  12/50 peers   664 bytes cache 0 bytes queue  RPC:  0 conn,    0 req/s,    0 µs
2019-01-04 13:48:08  Imported #9941183 0x8082…b4ff (0.47 Mgas) + another 154 header(s)
2019-01-04 13:48:08  Blocked connection to WebSockets server from untrusted origin: Some("file://")

@ltfschoen
Copy link
Contributor

Oh I just had to pass the option to trust that origin:

./target/release/parity --chain kovan --light --ws-origins=file://*

@ltfschoen ltfschoen self-assigned this Jan 7, 2019
amaury1093 added a commit that referenced this issue Feb 8, 2019
@amaury1093
Copy link
Collaborator

Closed by #332

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants