Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A couple of minor issues. #12

Open
ramiropolla opened this issue Jan 3, 2023 · 0 comments
Open

A couple of minor issues. #12

ramiropolla opened this issue Jan 3, 2023 · 0 comments

Comments

@ramiropolla
Copy link

This always evaluates to true:

EmonLibCM/emonLibCM.cpp

Lines 371 to 375 in 23ca81e

if (channel != 0 || channel != 1) // Attempt to deal with incompatibility with prior versions
{
_pin = channel;
channel = 0;
}

You probably mean _datalog_period_in_seconds here:

EmonLibCM/emonLibCM.cpp

Lines 325 to 326 in 23ca81e

if (datalog_period_in_seconds < 0.1)
datalog_period_in_seconds = 0.1;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant