Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove responsive components and make react-responsive a passthrough library #45

Closed
adamstankiewicz opened this issue Nov 23, 2021 · 0 comments
Assignees
Labels
paragon Paragon work ready to be picked up by FWG

Comments

@adamstankiewicz
Copy link
Member

adamstankiewicz commented Nov 23, 2021

Paragon ticket: https://openedx.atlassian.net/browse/PAR-473

Paragon utilizes the react-responsive NPM package in some components, as well as providing some helper components from react-responsive. However, often consumers of Paragon require additional responsive functionality than is offered through Paragon itself and as such resort to installing react-responsive as a standalone dependency in microfrontends.

If Paragon instead makes react-responsive a passthrough library, consumers of Paragon will be able to use react-responsive directly (by importing it from Paragon) rather than needing to install it separately. This shouldn’t necessarily have any impact on Paragon’s bundle size since react-bootstrap already ships with Paragon; just not all its functionality is importable by its consumers.

AC

  • Remove current responsive components (i.e., ExtraSmall, Small, Medium, Large, ExtraLarge, ExtraExtraLarge, LargerThanExtraSmall).
    • This is a breaking change.
  • Export all of react-responsive components/functions from Paragon such that they can may be imported by Paragon’s consumers.
    • useMediaQuery (named export)
    • MediaQuery (default export)
    • Context (named export)
  • Ensure Paragon's release notes describe the migration path from using the now-removed responsive components to using react-responsive directly from the passthrough instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paragon Paragon work ready to be picked up by FWG
Projects
None yet
Development

No branches or pull requests

2 participants