Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure tutor-contrib-coursegraph works with ENABLE_HTTPS #17

Closed
Tracked by #114
kdmccormick opened this issue Mar 23, 2022 · 1 comment
Closed
Tracked by #114

Ensure tutor-contrib-coursegraph works with ENABLE_HTTPS #17

kdmccormick opened this issue Mar 23, 2022 · 1 comment
Assignees
@kdmccormick

Comments

@kdmccormick
Copy link
Member

kdmccormick commented Mar 23, 2022 •
edited
Loading

In both local and k8s mode.
@kdmccormick kdmccormick changed the title Test tutor-contrib-coursegraph more thoroughly with k8s Test tutor-contrib-coursegraph k8s deployment more thoroughly Mar 23, 2022
@kdmccormick kdmccormick mentioned this issue Mar 23, 2022
Closed
@kdmccormick kdmccormick moved this to Ungroomed (Kyle) in Tutor DevEnv Adoption (OLD BOARD) Mar 23, 2022
@kdmccormick kdmccormick changed the title Test tutor-contrib-coursegraph k8s deployment more thoroughly Manually test tutor-contrib-coursegraph k8s deployment more thoroughly Mar 23, 2022
@kdmccormick kdmccormick mentioned this issue Mar 25, 2022
Closed
@kdmccormick kdmccormick changed the title Manually test tutor-contrib-coursegraph k8s deployment more thoroughly Ensure tutor-contrib-coursegraph works with ENABLE_HTTPS Mar 25, 2022
@kdmccormick
Copy link
Member Author

As it turns out, I don't have any reason to believe ENABLE_HTTPS wouldn't work with the plugin. I'd originally worried about this because an earlier version of the plugin would try to use Bolt/TLS for CMS->CourseGraph communication when ENABLE_HTTPS was set to True, but I removed that since it didn't seem important for CMS to encrypt it's cluster-internal communication with CourseGraph.

Repository owner moved this from Ungroomed (Kyle) to Closed in Tutor DevEnv Adoption (OLD BOARD) Mar 25, 2022
@kdmccormick kdmccormick added the wontfix This will not be worked on label Mar 25, 2022
@kdmccormick kdmccormick self-assigned this Mar 25, 2022
@kdmccormick kdmccormick closed this as not planned Won't fix, can't repro, duplicate, stale Feb 24, 2023
@kdmccormick kdmccormick removed the wontfix This will not be worked on label Feb 24, 2023
@kdmccormick kdmccormick moved this from 📥 New to 🚀 Closed in Developer Experience Working Group Mar 15, 2023
@kdmccormick kdmccormick mentioned this issue Mar 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kdmccormick kdmccormick

Labels
None yet
Projects
No open projects
Developer Experience Working Group
Status: Closed
Tutor DevEnv Adoption (OLD BOARD)
Status: Closed
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kdmccormick