Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve enrollment query performance by removing CTEs #556

Closed

Conversation

SoryRawyer
Copy link
Contributor

Following advice from Altinity, this PR removes CTEs from the fact_enrollments and fact_enrollments_by_day dataset queries. The Clickhouse benchmark tooling shows speedups and the query plans for these queries are shorter than before.

Following advice from Altinity, this PR removes CTEs from
the `fact_enrollments` and `fact_enrollments_by_day` dataset queries.
The Clickhouse benchmark tooling shows speedups and the query plans for
these queries are shorter than before.
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jan 8, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @SoryRawyer! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@SoryRawyer
Copy link
Contributor Author

Ah, after doing some more load testing, this seems to perform worse than the current version, so I'll close this.

@SoryRawyer SoryRawyer closed this Jan 9, 2024
@openedx-webhooks
Copy link

@SoryRawyer Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

1 similar comment
@openedx-webhooks
Copy link

@SoryRawyer Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants