Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement translations for Superset assets #36

Closed
bmtcril opened this issue May 4, 2023 · 5 comments · Fixed by #136
Closed

Implement translations for Superset assets #36

bmtcril opened this issue May 4, 2023 · 5 comments · Fixed by #136
Assignees

Comments

@bmtcril
Copy link
Contributor

bmtcril commented May 4, 2023

Superset has some amount of translation built in, but I haven't found much documentation about it. I think we need to add some capability into the OARS plugin itself to translate the dashboard and chart names if nothing else. We should be able to do this using the typical openedx translations project to get files in, but will probably have to find a way to roll our own project for doing the replacement at Tutor build time, and it will probably only support 1 language per install unless I misunderstand how Superset naming works.

@bmtcril bmtcril added the oars v1 label May 4, 2023
@Ian2012
Copy link
Contributor

Ian2012 commented May 23, 2023

As far as I know there is no support for dashboard translation: apache/superset#13030

There is a Superset Improvement Proposal, but seems stale at the moment apache/superset#13442

@bmtcril
Copy link
Contributor Author

bmtcril commented May 23, 2023

Yes, this would be something that we would implement at the OARS level that would translate the names as part of the Tutor jinja replacement, before they are created in Superset (it would still be one language per site, which is sad, but maybe better than having everything be in English?)

@Ian2012
Copy link
Contributor

Ian2012 commented Jul 4, 2023

I had an idea that I'm exploring:

  • Get the user language from a cookie, API call, or whatever. Important to be tied to the open edx platform.
  • At the authentication level assign two basic roles: Open edX which has minimal permissions and Open edX - {language} which has access to the translated dashboards for the given dashboards.
  • At the import level per a given asset (dashboard/charts) and a language, generate the assets with the corresponding translations.

This should be implemented for the course staff, and other roles like admins, data science, etc. would not be covered

@bmtcril
Copy link
Contributor Author

bmtcril commented Jul 5, 2023

This is a tough problem, but your solution is a lot better than mine was. What are the issues you see with staff / admin / etc getting translated assets?

@ielatifi
Copy link

ielatifi commented Mar 27, 2024

+1 for dashboards with automatic translation based on client region

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants