-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make other OARS plugins pip dependencies #17
Comments
What versioning system will we use for those plugins? Is it the same as tutor or will be an independent one? Is anything blocking this issue? |
I've talked about this with a few people and am still not settled on a best solution. I'd be interested in hearing more opinions. Here are some thoughts:
So my best current thought is that we should not actually make those other plugins hard dependencies of this one (and close this ticket), but I'm on the fence about how to version them together. There's value in keeping them all at the same minor version, and if any component has a breaking change doing a major version bump on them all. I think at least that way we'll be able to tell which versions are compatible at a glance. That would still be a manual process for the operators to decide which versions of each plugin to install in their Tutor environment, however. @mariajgrimaldi @pomegranited I'd love to hear your thoughts as well! |
With that being the case, we should use the same versioning system as tutor, so the plugins share a major version, and when there is a breaking change bump them all (as you said), and it's important to install the plugins as dependencies and use variables as established by the tutor standard to define if you want to run X service. This will also help us to refactor the code for production usage with all the different cases in which each service can communicate with the domain and not by the service name. Like in those cases, it would be way easier to implement optimizations in which if superset is running in the cluster use the service name: #35 (comment) |
@bmtcril This one can be closed |
I think we can make installation easier by simple requiring the correct versions of the other plugins in this one so they automatically get installed. They'll still need to be enabled manually, but it should save a few steps.
The text was updated successfully, but these errors were encountered: