Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GH Request] Remove tests as a required check in CI across multiple MFEs/JS libraries #282

Closed
BilalQamar95 opened this issue Sep 16, 2024 · 1 comment
Assignees

Comments

@BilalQamar95
Copy link

Repository

axim-engineering

Urgency

High (< 3 days)

Requested Change

Remove the tests status check as a required check in CI. This will prevent pipeline hang-ups and allow non-blocking test runs for Node v20 as part of the transitional phase where both Node v18 and Node v20 are in the CI matrix.

Reasoning

As part of the Node v20 upgrade process, Node v20 was added to the CI test matrix alongside Node v18. This has caused the tests status check to remain in a pending state, leading to pipeline hang-ups. In MFEs and JS libraries where the tests status check is marked as required, it should be removed to allow for test runs during this transitional phase.

Removing the tests check will prevent the CI pipeline from hanging while both Node v18 and Node v20 are tested, allowing the Node v20 upgrade process to move forward smoothly.

Copy link

Thank you for your report! @openedx/axim-oncall will triage within a business day. Simple requests usually take 2-3 business days to resolve; more complex requests could take longer.

@BilalQamar95 BilalQamar95 changed the title [GH Request] <Remove "tests" as a required check in CI across multiple MFEs/JS libraries> [GH Request] Remove tests as a required check in CI across multiple MFEs/JS libraries Sep 16, 2024
@brian-smith-tcril brian-smith-tcril self-assigned this Sep 16, 2024
@brian-smith-tcril brian-smith-tcril transferred this issue from openedx/axim-engineering Sep 17, 2024
@github-project-automation github-project-automation bot moved this from Backlog to Done in Axim Engineering Tasks Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants