[Product Pull Request] bug: Profile image on user posts

[jmakowski1123]

For Contributing Author:

This is the Primary Product Ticket for the following community contribution: New feature that will allow course instructors to manage certificates.

Checklist prior to undergoing Product Review:

The following information is required in order for Product Managers to be able to review your pull request:

• [ ] Explanation of the problem being solved
• [ ] Description of how users will be impacted, and which users will be impacted
• [ ] Screenshots or video showing the functionality or fix, before and after
• [ ] Reproduction steps and/or testing steps

Only if necessary:

• If necessary, links to corresponding configuration changes
• If necessary, links to corresponding enablement changes, particularly waffle/toggle status details

Related PRs

• feat: Profile image on user posts frontend-app-discussions#574
• feat: Profile image on user posts (palm.master) frontend-app-discussions#573
• feat: Profile image on user posts (quince.master) frontend-app-discussions#575

---

For Product Manager doing the review:

What criteria should be analyzed from Product to approve a PR?

• The problem being solved by the feature or fix is clear.
• There is clarity on how the change or fix will impact the end user.
• It is clear that the change will not negatively impact users or other areas of the platform.
• The change is implemented comprehensively.
• Any changes to UI use the current, standard Paragon Design System: https://paragon-openedx.netlify.app/

[github-actions]

Thanks for your submission, @openedx/open-edx-project-managers will review shortly.

[jmakowski1123]

There are a lot of open product questions that need to be addressed here.

• Is the scope of this PR limited to discussion forum posts?
• What's the background/context? What's the use case? Who has requested this feature and why? For example, is the request coming from learners? From instructors? From TAs? From moderators?
• Is the request to implement at the course level? At the instance or org level? Who makes the decisions about whether to implement it?
• What mechanisms will be in place to mitigate misuse of this feature? Ie, use of inappropriate images, etc. Did this come up in any of the user feedback?
• How does the feature work? How does a learner upload an image? Where does it happen in the workflow? Is there a full UX design?

[dyudyunov]

Hi @jmakowski1123

The user's profile image absence seemed to be a bug (while testing the Palm release) for us because it was present in the Olive release.

I just researched the feature changes history and found this PR where I believe the image was replaced with the placeholder. Unfortunately, I can't view the related Jira ticket and the PR description is too poor, so I don't know the motivation behind that change.

I think we could just close our PRs if our suggestion that this is a bug was wrong.

[jmakowski1123]

Let me do some testing on our new Quince branch.

[cassiezamparini]

@jmakowski1123 Has this been reviewed in Quince?

I've labelled this as a "bug" until we know more.

[mphilbrick211]

Hi all - any update on this one?

[dyudyunov]

Hi

Are there any updates on the issue?

[jmakowski1123]

I've looked at a bunch of live courses on edx.org, and they all have generic profile images. @ayub02 , can you confirm that this is actually the intended behavior for the discussion forums?

[mphilbrick211]

Hi @ayub02 and @jmakowski1123 - just checking in on this!

[ayub02]

Hi @mphilbrick211 ! Here's what i shared with Jenna. Please let me know what you think:
"Jenna, I discussed with the team. Profile picture feature has been removed from user profile due to requirements specific to 2U. Therefore, we removed profile pictures from discussion board long time ago (i think it was in late 2022 or early 2023).
We'll provide code review support if needed by community of Axim to display profile pictures on the discussion board. However, this change needs to be behind a control variable (e.g. waffle flag) so that it can be turned off for 2U instance."

[jmakowski1123]

Thanks @ayub02 . @dyudyunov Can this be developed behind a waffle flag? We can turn it on by default in the community release. If so, this has product approval.

[dyudyunov]

Hi @jmakowski1123

I think we could gate it using either a waffle flag on the backend or an additional config in the MFE env. The first option with the waffle flag seems better to me.

We'll plan further work on it

[ayub02]

Waffle flag sounds good to me. I'm ok with it enabled by default.

[mphilbrick211]

Hi @dyudyunov - just checking to see if there's an update on this one?

[dyudyunov]

@vladislavkeblysh please update your PRs according to the discussion results - add an option to toggle profile image displaying (default - is to display user profile image). It could be either a waffle flag or a new setting in the MFE env (the waffle flag - is a preferred solution)

• feat: Profile image on user posts frontend-app-discussions#574 - need to rebase and add the tool for switching the behaviour ^^. You'll need an edx-platform PR if you decide to use a waffle flag.
• feat: Profile image on user posts (palm.master) frontend-app-discussions#573 - should be closed now
• feat: Profile image on user posts (quince.master) frontend-app-discussions#575 - should be closed now
• The redwood backport PR should be added

[mphilbrick211]

Hi all - any update on this?

[vladislavkeblysh]

@mphilbrick211 Hi! in progress now

[vladislavkeblysh]

@mphilbrick211 Ready to review!

1. feat: Profile image on user posts frontend-app-discussions#574
2. feat: Profile image on user posts (redwood.master) frontend-app-discussions#746

[mphilbrick211]

@vladislavkeblysh thanks! Just to confirm - is product review complete on this?