From 14c83de803623d2de3fd5374be23e6f83776b12c Mon Sep 17 00:00:00 2001 From: Julian Ramirez Date: Wed, 8 Nov 2023 15:47:33 -0500 Subject: [PATCH 1/3] fix: undefined variable enrollment action in new enrollment request --- .../model/class-openedx-woocommerce-plugin-enrollment.php | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/includes/model/class-openedx-woocommerce-plugin-enrollment.php b/includes/model/class-openedx-woocommerce-plugin-enrollment.php index 417afcc..92258de 100644 --- a/includes/model/class-openedx-woocommerce-plugin-enrollment.php +++ b/includes/model/class-openedx-woocommerce-plugin-enrollment.php @@ -267,6 +267,10 @@ public function save_action( $post_id, $post ) { $enrollment_action = 'enrollment_sync'; } + if ( !isset( $enrollment_action ) ) { + $enrollment_action = ''; + } + $this->save_enrollment( $post, $enrollment_arr, $enrollment_action ); } From e3262761d7a489e667c9da587bd39b5ca8f88761 Mon Sep 17 00:00:00 2001 From: Julian Ramirez Date: Wed, 8 Nov 2023 15:51:16 -0500 Subject: [PATCH 2/3] refactor: added required space, wpcs rules --- includes/model/class-openedx-woocommerce-plugin-enrollment.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/includes/model/class-openedx-woocommerce-plugin-enrollment.php b/includes/model/class-openedx-woocommerce-plugin-enrollment.php index 92258de..64d0fec 100644 --- a/includes/model/class-openedx-woocommerce-plugin-enrollment.php +++ b/includes/model/class-openedx-woocommerce-plugin-enrollment.php @@ -267,7 +267,7 @@ public function save_action( $post_id, $post ) { $enrollment_action = 'enrollment_sync'; } - if ( !isset( $enrollment_action ) ) { + if ( ! isset( $enrollment_action ) ) { $enrollment_action = ''; } From b6cdd8310d50ad4b4b1546bc82e7fdfe51f009e0 Mon Sep 17 00:00:00 2001 From: Maria Fernanda Magallanes Zubillaga Date: Wed, 8 Nov 2023 16:45:36 -0500 Subject: [PATCH 3/3] refactor: improve the fix --- .../model/class-openedx-woocommerce-plugin-enrollment.php | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/includes/model/class-openedx-woocommerce-plugin-enrollment.php b/includes/model/class-openedx-woocommerce-plugin-enrollment.php index 64d0fec..8a09c7a 100644 --- a/includes/model/class-openedx-woocommerce-plugin-enrollment.php +++ b/includes/model/class-openedx-woocommerce-plugin-enrollment.php @@ -214,7 +214,8 @@ public function save_action( $post_id, $post ) { return; } - $enrollment_arr = array(); + $enrollment_arr = array(); + $enrollment_action = ''; if ( isset( $_POST['enrollment_course_id'] ) ) { $enrollment_arr['enrollment_course_id'] = sanitize_text_field( wp_unslash( $_POST['enrollment_course_id'] ) ); @@ -267,10 +268,6 @@ public function save_action( $post_id, $post ) { $enrollment_action = 'enrollment_sync'; } - if ( ! isset( $enrollment_action ) ) { - $enrollment_action = ''; - } - $this->save_enrollment( $post, $enrollment_arr, $enrollment_action ); }