fix: avoid using the email enrollment endpoint to fix a bug in versions without email support

[MaferMazu]

…

Description

When we add the new endpoint support in #44, we insert a bug. We tried to make an email enrollment, and in the previous version (Palm and Olive), this didn't fail, but we created an enrollment with the JWT token user, which is not the correct behavior.

To fix this, I only changed the second argument in get_enrollment_process_body to use the old form to request (with users). More info here.

Testing instructions

Install this plugin and perform enrollment requests in different versions of Open edX.

Check if you can enroll users and if you can perform course enrollments allowed.

Additional information

Without this change (The bug)

Screenshot of performing an enrollment with a user (Olmo version) - we perform this action with a user, and the plugin uses another user (the JWT token user).

With this change

Screenshot of performing an enrollment with a user (Olmo version)

Screenshot of performing an enrollment with a user (Quince version)

Screenshot of trying to enroll someone without an Open edX account without and with the enrollment allowed check, respectively (Quince version)

Checklist for Merge

• Tested in a remote environment
• Updated documentation
• Rebased master/main
• Squashed commits

[openedx-webhooks]

Thanks for the pull request, @MaferMazu! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

• supporting documentation
• Open edX discussion forum threads
• timeline information ("this must be merged by XX date", and why that is)
• partner information ("this is a course on edx.org")
• any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

[MaferMazu]

Hello @julianramirez2, can you help me review this, please?

[MaferMazu]

Hello @felipemontoya, can you help me review this, please?

[felipemontoya]

This PR works by changing the value passed to $use_old_endpoint from false to true. As such it will definitely work to fix the regression.

What I'm wondering is what would be the long term plan? Do we wait a few releases and turn it back on? Since the API is exactly the same version after openedx/edx-platform#33006 the only way to know for sure that the email worked would be to call the API and then look at the answer, but by then the incorrect enrollment would already have been created.

I'm good with merging this changes as is, but I still wanted to know the plans for the future.

[felipemontoya]

As I said, were good to merge this to fix the bug

[MaferMazu]

What I'm wondering is what would be the long term plan? Do we wait a few releases and turn it back on?

Yes, we could use email directly when Quince is the oldest Open edX support.
But I think maybe we want to maintain the old enrollment endpoints to not break the backward compatibility at some point.

I don't have a strong position regarding this, but we can discuss it and decide the best in terms of maintenance and usability.

[openedx-webhooks]

@MaferMazu 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.