Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show enrollment status in enrollments table #56

Merged
merged 2 commits into from
Nov 8, 2023

Conversation

julianramirez2
Copy link
Contributor

@julianramirez2 julianramirez2 commented Oct 26, 2023

Description

Now, in the enrollments, an additional piece of information will be displayed, which is the status. The status can be 'success,' 'error,' or 'no process,' indicating whether the last request was successful, encountered an error, or if no process was necessary (in the case of saving the enrollment locally).

Testing instructions

Pull the branch locally and run the 'composer install' command to install all plugin dependencies and test.

Additional information

To filter and search for enrollments based on their status, it's as simple as typing the desired status into the search bar located at the top right corner of the enrollments.

Checklist for Merge

  • Tested in a remote environment
  • Updated documentation N/A
  • Rebased master/main N/A
  • Squashed commits N/A

@openedx-webhooks
Copy link

openedx-webhooks commented Oct 26, 2023

Thanks for the pull request, @julianramirez2! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 26, 2023
Copy link
Contributor

@MaferMazu MaferMazu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR @julianramirez2, the feature is working as expected.
With this change you are going to be able to see the status of the last requests.
image
I have some questions only for improve the code, but the rest looks good to me.

@julianramirez2
Copy link
Contributor Author

@andres-arango-aptitude can you check this, please?

Copy link
Contributor

@MaferMazu MaferMazu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank @julianramirez2, for resolving the issues.

@MaferMazu MaferMazu merged commit b1348f3 into openedx:main Nov 8, 2023
4 checks passed
@openedx-webhooks
Copy link

@julianramirez2 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants