-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: show enrollment status in enrollments table #56
Conversation
Thanks for the pull request, @julianramirez2! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR @julianramirez2, the feature is working as expected.
With this change you are going to be able to see the status of the last requests.
I have some questions only for improve the code, but the rest looks good to me.
@andres-arango-aptitude can you check this, please? |
1b0cb10
to
5efab09
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank @julianramirez2, for resolving the issues.
@julianramirez2 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Description
Now, in the enrollments, an additional piece of information will be displayed, which is the status. The status can be 'success,' 'error,' or 'no process,' indicating whether the last request was successful, encountered an error, or if no process was necessary (in the case of saving the enrollment locally).
Testing instructions
Pull the branch locally and run the 'composer install' command to install all plugin dependencies and test.
Additional information
To filter and search for enrollments based on their status, it's as simple as typing the desired status into the search bar located at the top right corner of the enrollments.
Checklist for Merge