Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: post translation validation errors as a GitHub comment | FC-0012 #1879

Closed

Conversation

OmarIthawi
Copy link
Member

@OmarIthawi OmarIthawi commented Oct 18, 2023

This contribution is part of the FC-0012 project which is sparked by the Translation Infrastructure update OEP-58.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 18, 2023
@openedx-webhooks
Copy link

Thanks for the pull request, @OmarIthawi! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

This is currently a draft pull request. When it is ready for our review and all tests are green, click "Ready for Review", or remove "WIP" from the title, as appropriate.

@OmarIthawi OmarIthawi changed the title feat: post translation validation errors as a GitHub comment feat: post translation validation errors as a GitHub comment | FC-0012 Oct 18, 2023
100% translated source file: 'django.po'
on 'pt_BR'.
@OmarIthawi OmarIthawi force-pushed the python_validate_translations branch 9 times, most recently from 1f26ae4 to eca51e4 Compare October 18, 2023 15:12
@OmarIthawi OmarIthawi force-pushed the python_validate_translations branch from eca51e4 to 29fdf7c Compare October 18, 2023 15:14
@OmarIthawi
Copy link
Member Author

Closing in favor of #1894

@OmarIthawi OmarIthawi closed this Oct 18, 2023
@openedx-webhooks
Copy link

@OmarIthawi Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

1 similar comment
@openedx-webhooks
Copy link

@OmarIthawi Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

@itsjeyd itsjeyd added the core contributor PR author is a Core Contributor (who may or may not have write access to this repo). label Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants