Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sync all supported langs #1482

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

OmarIthawi
Copy link
Member

@OmarIthawi OmarIthawi commented Oct 9, 2023

Description

We're syncing the languages from the old project ( https://app.transifex.com/open-edx/edx-platform/ ) to the new project ( https://app.transifex.com/open-edx/openedx-translations/ ) on Transifex.

This pull request includes all supported languages in the Open edX project:

Future work

Another update is required to include all the languages that might be supported in the future. Related discussion on Slack.

Reference

This contribution is part of the FC-0012 project which is sparked by the Translation Infrastructure update OEP-58.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 9, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Oct 9, 2023

Thanks for the pull request, @OmarIthawi! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@OmarIthawi OmarIthawi marked this pull request as ready for review October 10, 2023 07:53
Makefile Outdated
export TX_LANGUAGES := ar,de,fr_CA
# This includes languages which are translatie
# This list should be all the languages Open edX supports until the migration is complete.
export TX_LANGUAGES := ar,da,de_DE,el,es-149,es_ES,fr_CA,hi,id,it_IT,pt_BR,pt_PT,ru,th,tr_TR,uk,zh_CN
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hebrew is in the table but without a code

Suggested change
export TX_LANGUAGES := ar,da,de_DE,el,es-149,es_ES,fr_CA,hi,id,it_IT,pt_BR,pt_PT,ru,th,tr_TR,uk,zh_CN
export TX_LANGUAGES := ar,da,de_DE,el,es-149,es_ES,fr_CA,hi,he,id,it_IT,pt_BR,pt_PT,ru,th,tr_TR,uk,zh_CN

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've fixed the table

@OmarIthawi OmarIthawi force-pushed the supported-langs-sync branch from 0824a01 to caa7f87 Compare October 10, 2023 08:19
@OmarIthawi OmarIthawi merged commit 291ec6f into openedx:main Oct 10, 2023
@openedx-webhooks
Copy link

@OmarIthawi 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@itsjeyd itsjeyd added the core contributor PR author is a Core Contributor (who may or may not have write access to this repo). label Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants