Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't fail after merging Transifex GitHub App pull requests FC-0012 #1070

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

OmarIthawi
Copy link
Member

@OmarIthawi OmarIthawi commented Sep 12, 2023

otherwise it'll complain a lot about mergedAt being null such as: https://github.com/openedx/openedx-translations/actions/runs/6153503626/job/16697476155

TODO

  • Test on my fork: I've tested locally, but I'll save some time by merging and waiting imo.

This contribution is part of the FC-0012 project which is sparked by the Translation Infrastructure update OEP-58.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Sep 12, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Sep 12, 2023

Thanks for the pull request, @OmarIthawi! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@OmarIthawi OmarIthawi changed the title fix: don't fail after merging Transifex GitHub App pull requests fix: don't fail after merging Transifex GitHub App pull requests FC-0012 Oct 13, 2023
@OmarIthawi OmarIthawi changed the title fix: don't fail after merging Transifex GitHub App pull requests FC-0012 fix: don't fail after merging Transifex GitHub App pull requests FC-0012 Oct 13, 2023
otherwise it'll complain a lot about mergedAt being null
@OmarIthawi OmarIthawi marked this pull request as ready for review October 16, 2023 10:57
Copy link
Contributor

@shadinaif shadinaif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @OmarIthawi

@OmarIthawi OmarIthawi merged commit 11b1828 into openedx:main Oct 16, 2023
4 checks passed
@openedx-webhooks
Copy link

@OmarIthawi 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@OmarIthawi
Copy link
Member Author

Thanks @shadinaif.

It seems to be working fine:

image

cc: @brian-smith-tcril

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants