Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event design and naming how-to #76

Closed
robrap opened this issue Jul 11, 2022 · 3 comments
Closed

Event design and naming how-to #76

robrap opened this issue Jul 11, 2022 · 3 comments

Comments

@robrap
Copy link
Contributor

robrap commented Jul 11, 2022

We should consider adding a how-to for adding events, that may pull from and reference ADRs, but would be a clear how-to document.

One potentially missing detail, is whether all Data objects should have the suffix "Data"? See

class DiscussionTopicContext:
for one example that doesn't match this convention. Separate and related, do we want linting to help enforce any conventions?

Do we want to document known subdomains? (I have additional questions about this, but better left to a separate issue.)

@mariajgrimaldi
Copy link
Member

mariajgrimaldi commented Jul 12, 2022

We should consider adding a how-to for adding events

Yes, I remember doing this for the conference. I'll brush up on what I wrote in a new PR.

One potentially missing detail, is whether all Data objects should have the suffix "Data"?

During the event's design, our primary focus was: event identification & the implemented name of the event, which we added in the naming conventions ADR, so the data classes were created more organically. Now, we should decide if we need to make that naming a convention.

@mariajgrimaldi
Copy link
Member

mariajgrimaldi commented Jul 20, 2022

I opened a PR with the how-to draft: #80

@mariajgrimaldi
Copy link
Member

I'll close this as completed by #80

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants