Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: modernize repo supporting latest django-app cookiecutter changes #322

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

mariajgrimaldi
Copy link
Member

@mariajgrimaldi mariajgrimaldi commented Feb 26, 2024

Description:
This PR changes:

  • The main CI workflow: adding support for Django 3.2 and Django 4.2 testing environments
  • tox.ini: adding the necessary configurations for multiple django versions
  • Constraint files: currently, for this kind of repo constraints are read from the edx-lint repository https://github.com/openedx/edx-lint/blob/master/edx_lint/files/common_constraints.txt
  • Makefile: removing unnecessary common_constraints file since it was removed in favor of the previous item, and test requirements with multiple django versions

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Feb 26, 2024
@openedx-webhooks
Copy link

openedx-webhooks commented Feb 26, 2024

Thanks for the pull request, @mariajgrimaldi! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@mariajgrimaldi mariajgrimaldi changed the title build: add support for django42 during GH workflows build: modernize repo supporting latest django-app cookiecutter changes Feb 26, 2024
@mariajgrimaldi mariajgrimaldi changed the title build: modernize repo supporting latest django-app cookiecutter changes chore: modernize repo supporting latest django-app cookiecutter changes Feb 26, 2024
@mariajgrimaldi mariajgrimaldi marked this pull request as ready for review February 26, 2024 16:18
@mariajgrimaldi mariajgrimaldi requested a review from a team as a code owner February 26, 2024 16:18
@mariajgrimaldi mariajgrimaldi marked this pull request as draft February 26, 2024 16:18
@mariajgrimaldi mariajgrimaldi removed the request for review from a team February 26, 2024 16:19
@mariajgrimaldi mariajgrimaldi marked this pull request as ready for review February 26, 2024 18:13
@mariajgrimaldi mariajgrimaldi requested a review from a team February 26, 2024 18:13
@Ian2012 Ian2012 merged commit 912ecc0 into main Mar 4, 2024
9 checks passed
@Ian2012 Ian2012 deleted the MJG/support-django-42 branch March 4, 2024 11:41
@openedx-webhooks
Copy link

@mariajgrimaldi 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants