From 18e7ade1cec4e374514907c12a23d76cc9ea9ce5 Mon Sep 17 00:00:00 2001 From: Tim McCormack Date: Tue, 16 Aug 2022 15:00:28 -0400 Subject: [PATCH] feat!: Removed `org` and `number` fields from `CourseCatalogData` (#95) These are redundant with course key and can be added back in later if we actually need them. This is a breaking change but it should only affect event-bus code that hasn't yet been merged. See discussion here: https://github.com/openedx/openedx-events/issues/72#issuecomment-1212177933 --- CHANGELOG.rst | 5 +++++ openedx_events/__init__.py | 2 +- openedx_events/content_authoring/data.py | 4 ---- 3 files changed, 6 insertions(+), 5 deletions(-) diff --git a/CHANGELOG.rst b/CHANGELOG.rst index 77569c6c..b7a5015b 100644 --- a/CHANGELOG.rst +++ b/CHANGELOG.rst @@ -13,8 +13,13 @@ Change Log Unreleased ---------- + +[0.12.0] - 2022-08-16 +--------------------- Changed ~~~~~~~ +* **Breaking change**: Removed ``org`` and ``number`` fields from ``CourseCatalogData`` + (should only affect unreleased event-bus code, though) [0.11.1] - 2022-07-28 --------------------- diff --git a/openedx_events/__init__.py b/openedx_events/__init__.py index 87c7b19e..e538a131 100644 --- a/openedx_events/__init__.py +++ b/openedx_events/__init__.py @@ -5,4 +5,4 @@ more information about the project. """ -__version__ = "0.11.1" +__version__ = "0.12.0" diff --git a/openedx_events/content_authoring/data.py b/openedx_events/content_authoring/data.py index d79e6634..b06c520b 100644 --- a/openedx_events/content_authoring/data.py +++ b/openedx_events/content_authoring/data.py @@ -41,8 +41,6 @@ class CourseCatalogData: Arguments: course_key (CourseKey): identifier of the Course object. name (str): course name - org (str): course organization identifier - number (str): course number schedule_data (CourseScheduleData): scheduling information for the course short_description (str): one- or two-sentence course description (optional) effort (str): estimated level of effort in hours per week (optional). Kept as a str to align with the lms model. @@ -53,8 +51,6 @@ class CourseCatalogData: # basic identifiers course_key = attr.ib(type=CourseKey) name = attr.ib(type=str) - number = attr.ib(type=str) - org = attr.ib(type=str) # additional marketing information schedule_data = attr.ib(type=CourseScheduleData)