From 5a6acb1d6b4b94f7d64a4a6e03980154b0696db2 Mon Sep 17 00:00:00 2001 From: Feanil Patel Date: Tue, 19 Mar 2024 23:40:08 -0400 Subject: [PATCH] fix: Fix new pylint warnings. * `no-self-use` is now an optional value. We don't need to disable it manually because it's disabled by default. * We had some superflous parens in the symmath_check.py file so we remove those as well. --- pylintrc | 3 +-- pylintrc_tweaks | 1 - symmath/symmath_check.py | 2 +- 3 files changed, 2 insertions(+), 4 deletions(-) diff --git a/pylintrc b/pylintrc index 9d57a7b..fddcfdb 100644 --- a/pylintrc +++ b/pylintrc @@ -287,7 +287,6 @@ disable = illegal-waffle-usage, logging-fstring-interpolation, - no-self-use, django-not-available, [REPORTS] @@ -385,4 +384,4 @@ int-import-graph = [EXCEPTIONS] overgeneral-exceptions = builtins.Exception -# 37fb074922e492cc9d7946220ba214f767ee70f1 +# f90fb567b1f44429c280e9de9c5d874fb1d81d25 diff --git a/pylintrc_tweaks b/pylintrc_tweaks index dfd47a7..9282ab3 100644 --- a/pylintrc_tweaks +++ b/pylintrc_tweaks @@ -5,5 +5,4 @@ load-plugins = edx_lint.pylint,pylint_django,pylint_celery [MESSAGES CONTROL] disable+ = - no-self-use, django-not-available, diff --git a/symmath/symmath_check.py b/symmath/symmath_check.py index bfb1fa4..343c9a8 100644 --- a/symmath/symmath_check.py +++ b/symmath/symmath_check.py @@ -324,7 +324,7 @@ def symmath_check(expect, ans, dynamath=None, options=None, debug=None, xml=None #fsym = fsym.simplify() #fexpect = fexpect.simplify() try: - diff = (fexpect - fsym) + diff = fexpect - fsym except Exception as err: # lint-amnesty, pylint: disable=broad-except diff = None