Quick Fix for primary enrolment data #492
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forgotvas
previously approved these changes
Jul 11, 2024
saeedbashir
reviewed
Jul 12, 2024
Comment on lines
55
to
72
| public init(from decoder: Decoder) throws { | ||
| let values = try decoder.container(keyedBy: CodingKeys.self) | ||
|
|
||
| if let dateString = try? values.decode(String.self, forKey: .auditAccessExpires) { | ||
| auditAccessExpires = Date(iso8601: dateString) | ||
| } else { | ||
| auditAccessExpires = nil | ||
| } | ||
| created = try? values.decode(String.self, forKey: .created) | ||
| mode = try? values.decode(String.self, forKey: .mode) | ||
| isActive = try? values.decode(Bool.self, forKey: .isActive) | ||
| course = try? values.decode(DashboardCourse.self, forKey: .course) | ||
| certificate = try? values.decode(Certificate.self, forKey: .certificate) | ||
| courseModes = try? values.decode([CourseMode].self, forKey: .courseModes) | ||
| courseStatus = try? values.decode(CourseStatus.self, forKey: .courseStatus) | ||
| progress = try? values.decode(CourseProgress.self, forKey: .progress) | ||
| courseAssignments = try? values.decode(CourseAssignments.self, forKey: .courseAssignments) | ||
| } |
There was a problem hiding this comment.
If the decoder is only introduced for audit_access_expires, that can be omitted by changing the auditAccessExpires type from Date? to String?
There was a problem hiding this comment.
agreed. changed type to String
forgotvas
approved these changes
Jul 12, 2024
rnr
force-pushed
the
fix/PrimaryEnrollment_data
branch
from
8a2927d to
f365d75
Compare
|
We're closing this PR and moving these changes to our own fork, as they are critical for us. After our release, we hope to find a way to contribute these changes back, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is quick fix for #491
Changed type of
auditAccessExpiresto String.