Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: catch exception when parsing file for transcription #406

Merged

Conversation

dixidroid
Copy link
Contributor

try/catch block was missed for the second case when transcriptInputStream == null

…rse_exception

# Conflicts:
#	core/src/main/java/org/openedx/core/module/TranscriptManager.kt
Copy link
Contributor

@PavloNetrebchuk PavloNetrebchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@volodymyr-chekyrta volodymyr-chekyrta merged commit c6b8fa5 into openedx:develop Nov 18, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants