Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: set dataValue to true for CourseOutline #404

Merged
merged 2 commits into from
Nov 18, 2024
Merged

fix: set dataValue to true for CourseOutline #404

merged 2 commits into from
Nov 18, 2024

Conversation

dixidroid
Copy link
Contributor

Description:

  • set DataValue to true for valid courseOutline
  • fixed ValueProp Button Visibility & CalendarSync button
  • Handle ErrorLayout for exceptions

@dixidroid
Merge remote-tracking branch 'origin/develop' into fix/omer/bug_fixes
d14ccdf 
# Conflicts:
#	course/src/main/java/org/openedx/course/presentation/container/CourseContainerViewModel.kt
PavloNetrebchuk
PavloNetrebchuk approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@PavloNetrebchuk PavloNetrebchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGFM

@volodymyr-chekyrta volodymyr-chekyrta merged commit 1a3826a into openedx:develop Nov 18, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PavloNetrebchuk PavloNetrebchuk PavloNetrebchuk approved these changes

@volodymyr-chekyrta volodymyr-chekyrta volodymyr-chekyrta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dixidroid @volodymyr-chekyrta @PavloNetrebchuk @omerhabib26