Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tagging] Rename and delete an individual tag #131

Open
Tracked by #239
bradenmacdonald opened this issue Sep 22, 2023 · 1 comment
Open
Tracked by #239

[Tagging] Rename and delete an individual tag #131

bradenmacdonald opened this issue Sep 22, 2023 · 1 comment
Labels
pending UX changes This issue (not a PR) needs UX input or its UX design is not yet finalized.

Comments

@bradenmacdonald
Copy link
Contributor

bradenmacdonald commented Sep 22, 2023

"As a global staff user (instance-level super admin), I can rename or delete individual tags in a taxonomy."

Acceptance Criteria

  1. On the Taxonomy Detail Page, users with permission to edit the taxonomy (only global staff for now) should see this "three dots" menu for each tag with "Rename" and "Delete" as options:
    Screenshot 2023-09-22 at 11 25 23 AM
  2. Clicking rename will make the tag name editable in-place:
    Screenshot 2023-09-22 at 11 28 00 AM
  3. Pressing ENTER or clicking elsewhere on the page will save the new name and display a toast. Pressing ESC will cancel the rename.
    Screenshot 2023-09-22 at 11 28 40 AM
  4. If "Delete" is selected, this dialog will be shown:
    Screenshot 2023-09-22 at 11 30 25 AM
  5. But if some of the tags have subtags, this other dialog will be shown instead.
    Screenshot 2023-09-25 at 11 05 56 AM
  6. Upon confirmation, a toast is shown with a working Undo button.
    Screenshot 2023-09-22 at 11 34 16 AM
  7. The "Type DELETE to confirm" dialog needs to work in other languages ("Escribe BORRAR para confirmar")
  8. Make sure the whole workflow is keyboard accessible.

Developer Notes

  • Don't check "is the user global staff"; check "does the user have edit permission for this taxonomy" which in turn should be defined using a rule that only global staff have that permission.
  • Screenshots above are for convenience - Figma is the most up-to-date source for mockups. The scale of UI elements seen in the screenshots above may be incorrect.
@ali-hugo
Copy link

ali-hugo commented Oct 12, 2023

@bradenmacdonald We have added a "save" and "cancel" button to the end of the row of the tag that is being edited (the save button remains disabled until the text has been edited):

Screenshot 2023-10-12 at 10 20 30

Please update point 3 in the description to something like:
"Pressing ENTER or selecting the SAVE button will save the new name and display a toast. Pressing ESC or selecting the CANCEL button will cancel the rename".

Note that "clicking elsewhere on the page" no longer cancels the rename.


It might be worth mentioning what happens if the name change affects the tag's position alphabetically in the list i.e. the tag remains where it is currently until the page reloads or the user selects the sort icon next to the column title.


Let me know if there's anything else you need before the "pending UX changes" label can be removed from this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending UX changes This issue (not a PR) needs UX input or its UX design is not yet finalized.
Projects
Development

No branches or pull requests

2 participants