Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tagging] View/edit tags for a library component #121

Closed
Tracked by #34
bradenmacdonald opened this issue Sep 21, 2023 · 6 comments · Fixed by openedx-unsupported/frontend-app-library-authoring#400

Comments

@bradenmacdonald
Copy link
Contributor

bradenmacdonald commented Sep 21, 2023

"As a Content Author, I can add/delete tags to content components (text blocks, video blocks, problem blocks) in a v2 Library."

"As a Content author, I can view tags that have already been added to content components in a v2 Library."

"As a Content Author, I expect that the experience to view, add and delete tags to content components mirrors the UI and experience when I view, add and delete tags to component xblocks on a Unit Page in a course."

Acceptance Criteria

  1. From the new libraries MFE, I can select "Manage Tags" for any library component
    Screenshot 2023-09-21 at 3 04 54 PM

In the library authoring MFE, it would look more like this:
Screenshot 2023-12-19 at 11 59 03 AM

  1. The existing "Delete" icon should be moved to become a "Delete" item in the three dots menu.

  2. Clicking "Manage Tags" opens the tagging drawer with the same tag viewing and editing functionality as units and course components have.

  3. I can add/remove tags using the tagging drawer.

  4. Components that have at least one tag display the total tag count as a clickable button, just like on the unit page:

Note: this is just showing where the "tag count button" goes in the new MFE. This is not how it should look:

Screenshot 2023-12-19 at 11 57 23 AM

It should look something more like this, but in the style of the new MFE:

Screenshot 2023-12-19 at 11 56 25 AM

  1. For now this can just open the tag drawer in an iframe, but based on [Tagging] Discovery: Move the library-authoring MFE into the course-authoring MFE #164 we'll find a better way to integrate it.

  2. This is all for v2 libraries only; no need to support v1. The library URL/ID should start with lib:, which indicates a v2 library.

@bradenmacdonald bradenmacdonald added the blocked by other work PR cannot be finished until other work is complete label Sep 21, 2023
@jmakowski1123 jmakowski1123 moved this from MVP - No Status to Post-MVP Ideas - not prioritized in Modular Learning - Tagging and Libraries Nov 13, 2023
@bradenmacdonald bradenmacdonald removed the blocked by other work PR cannot be finished until other work is complete label Dec 19, 2023
@bradenmacdonald
Copy link
Contributor Author

@jmakowski1123 @ali-hugo please review the UI here, and if you can provide a mockup of exactly how you'd like it to look, it would be super helpful.

@bradenmacdonald
Copy link
Contributor Author

@jmakowski1123 @ali-hugo Scratch that - please look at openedx-unsupported/frontend-app-library-authoring#400

@ali-hugo
Copy link

ali-hugo commented Jan 8, 2024

@bradenmacdonald #400 looks good! My only feedback would be that the pencil icon should match the "icon + edit" element used elsewhere in Studio (see screenshot below), but I think this might fall outside of the ticket scope. I thought I'd mention it in case it doesn't.

Screenshot 2024-01-08 at 11 33 09

@bradenmacdonald
Copy link
Contributor Author

bradenmacdonald commented Jan 8, 2024

@ali-hugo That's outside the scope here, as 2U already settled on that pencil icon for the new MFE. If you'd like to change it, could you discuss it with Jon? (Edit: actually as this is the Library Authoring MFE, not Course Authoring MFE, I'm not actually sure who made the decision)

@ali-hugo
Copy link

ali-hugo commented Jan 9, 2024

@bradenmacdonald

@jmakowski1123 @ali-hugo please review the UI here, and if you can provide a mockup of exactly how you'd like it to look, it would be super helpful.

@jmakowski1123 and I chatted briefly about the Library Authoring MFE. It should be up soon 🤞 . Would it suit you for us to wait for it to go live before weighing in on any related design decisions?

@bradenmacdonald
Copy link
Contributor Author

@ali-hugo Yep that's fine. We have solved the issues with our sandbox today, so it should be working by tomorrow, including the libraries MFE.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

2 participants