-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tagging] Add "Expand All" button to Taxonomy View #112
Comments
This functionality has already been added to the tags list using DataTable's expandable rows feature. So this ticket about moving that "expand all" button into the table header, as per the designs, which might require changes to paragon. CC @bradenmacdonald |
@ali-hugo do you think we can just leave this as-is for MVP? I know the Figma are more wireframes than finalized UX, so I'm thinking if the "Expand All" is basically present and working, it's not worth spending much time on this now until after we've had a round of user testing and feedback. So @pomegranited I'm thinking let's just call this done for now, but wait to see what Ali says. We can put any follow-ups into #155 which is probably a better idea anyways since we'll have to make sure we account for things like dragging tags around, multi-select of tags, keyword filtering, etc. I think we can still do all of that using this same as a basis but things could change. Here's how it looks now: |
FYI @ChrisChV ^ |
@bradenmacdonald @pomegranited @ChrisChV Yes, I think this is ok to leave as is for MVP. The only thing I think might be worth tweaking (but only if it's a quick change), would be to lose the "child tags" column, and rather include a little gray number next to the parent tags (just like the child tags have). But if that's not a simple fix, I think @bradenmacdonald's right when he says we should leave this as is until we have some user feedback. 👍 |
@ali-hugo Yep that should be a simple change, and we can include that in #157 . CC @pomegranited. |
The text was updated successfully, but these errors were encountered: