Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct rtl for handouts #1289

Merged
merged 1 commit into from
Mar 13, 2024
Merged

Conversation

dyudyunov
Copy link
Contributor

This was already merged into Palm #1192

Before the fix:

Screenshot 2024-02-09 at 18 01 14

After the fix:

Screenshot 2024-02-09 at 17 23 57

@openedx-webhooks
Copy link

Thanks for the pull request, @dyudyunov! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Feb 9, 2024
Copy link

codecov bot commented Feb 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (efd57c3) 88.35% compared to head (57061c5) 88.35%.
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1289   +/-   ##
=======================================
  Coverage   88.35%   88.35%           
=======================================
  Files         291      291           
  Lines        4936     4937    +1     
  Branches     1242     1243    +1     
=======================================
+ Hits         4361     4362    +1     
  Misses        561      561           
  Partials       14       14           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@itsjeyd
Copy link

itsjeyd commented Feb 16, 2024

@dyudyunov Same here, I'll mark this PR as ready for review now.

@itsjeyd
Copy link

itsjeyd commented Feb 16, 2024

Master PR for #1192 (Palm) and #1288 (Quince).

@itsjeyd itsjeyd added the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Feb 16, 2024
@itsjeyd
Copy link

itsjeyd commented Mar 11, 2024

@openedx/2u-aurora Same question here, could you have a quick look at this backport PR and merge it?

Copy link

@arbrandes arbrandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Plus, it's already in Palm and Quince anyway.

@arbrandes arbrandes merged commit c3b786c into openedx:master Mar 13, 2024
7 checks passed
@openedx-webhooks
Copy link

@dyudyunov 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@dyudyunov dyudyunov deleted the fix-handouts-rtl branch March 14, 2024 07:18
@itsjeyd itsjeyd removed the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants