-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: correct rtl for handouts #1289
Conversation
Thanks for the pull request, @dyudyunov! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1289 +/- ##
=======================================
Coverage 88.35% 88.35%
=======================================
Files 291 291
Lines 4936 4937 +1
Branches 1242 1243 +1
=======================================
+ Hits 4361 4362 +1
Misses 561 561
Partials 14 14 ☔ View full report in Codecov by Sentry. |
@dyudyunov Same here, I'll mark this PR as ready for review now. |
@openedx/2u-aurora Same question here, could you have a quick look at this backport PR and merge it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Plus, it's already in Palm and Quince anyway.
@dyudyunov 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
This was already merged into Palm #1192
Before the fix:
After the fix: