Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added implementation for new sidebar #1260

Merged
merged 11 commits into from
Jan 8, 2024
Merged

Conversation

sundasnoreen12
Copy link
Contributor

@sundasnoreen12 sundasnoreen12 commented Dec 27, 2023

INF-1184

Description
Stack notifications panel on top of discussions based on Legacy Notifications vs Discussions Sidebar

When a user navigates to a unit, the sidebar should open when:

  1. Audit user: Notification is available for the panel.
  2. Audit user: Course is using Openedx provider and Discussion is enabled on this unit.
  3. Audit user: Course is using Openedx provider and Discussion is enabled on this unit and Notification is available for the panel.
  4. Verified user: Course is using Openedx provider and Discussion is enabled on this unit.

Sidebar should open irrespective of whether the user has closed it on the previous unit they visited.

Screenshots
Screenshot 2024-01-03 at 5 23 28 PM

Screenshot 2023-12-26 at 6 55 29 PM

Copy link

codecov bot commented Dec 27, 2023

Codecov Report

Attention: 103 lines in your changes are missing coverage. Please review.

Comparison is base (600f5b4) 87.98% compared to head (ba26b35) 86.24%.

Files Patch % Lines
...ware/course/new-sidebar/SidebarContextProvider.jsx 7.89% 35 Missing ⚠️
...-notifications/DiscussionsNotificationsTrigger.jsx 8.82% 31 Missing ⚠️
...urseware/course/new-sidebar/common/SidebarBase.jsx 14.28% 18 Missing ⚠️
.../courseware/course/new-sidebar/SidebarTriggers.jsx 14.28% 6 Missing ⚠️
src/courseware/course/new-sidebar/Sidebar.jsx 20.00% 4 Missing ⚠️
...-notifications/DiscussionsNotificationsSidebar.jsx 20.00% 4 Missing ⚠️
...re/course/new-sidebar/icons/RightSidebarFilled.jsx 50.00% 1 Missing ⚠️
.../course/new-sidebar/icons/RightSidebarOutlined.jsx 50.00% 1 Missing ⚠️
...otifications/notifications/NotificationsWidget.jsx 88.88% 1 Missing ⚠️
src/courseware/course/sequence/Sequence.jsx 80.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1260      +/-   ##
==========================================
- Coverage   87.98%   86.24%   -1.75%     
==========================================
  Files         276      290      +14     
  Lines        4745     4891     +146     
  Branches     1197     1234      +37     
==========================================
+ Hits         4175     4218      +43     
- Misses        554      657     +103     
  Partials       16       16              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

.env Outdated Show resolved Hide resolved
.env.development Outdated Show resolved Hide resolved
src/courseware/course/Course.jsx Outdated Show resolved Hide resolved
src/courseware/course/new-sidebar/NewSidebarIcon.jsx Outdated Show resolved Hide resolved
src/courseware/course/new-sidebar/NewSidebarIcon.jsx Outdated Show resolved Hide resolved
src/courseware/course/new-sidebar/NewSidebarIcon.jsx Outdated Show resolved Hide resolved
src/index.jsx Outdated Show resolved Hide resolved
src/generic/upgrade-notification/UpgradeNotification.scss Outdated Show resolved Hide resolved
@sundasnoreen12 sundasnoreen12 merged commit 023f5ac into master Jan 8, 2024
4 of 6 checks passed
@sundasnoreen12 sundasnoreen12 deleted the sundas/INF-1184 branch January 8, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants