-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added implementation for new sidebar #1260
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sundasnoreen12
force-pushed
the
sundas/INF-1184
branch
from
December 27, 2023 09:00
1ee355b
to
fe36b0d
Compare
sundasnoreen12
requested review from
ayesha-waris,
muhammadadeeltajamul and
awais-ansari
December 27, 2023 09:27
awais-ansari
requested changes
Dec 27, 2023
src/courseware/course/new-sidebar/icons/SvgRightSidebarOutlined.jsx
Outdated
Show resolved
Hide resolved
src/courseware/course/new-sidebar/icons/SvgRightSidebarFilled.jsx
Outdated
Show resolved
Hide resolved
awais-ansari
requested changes
Dec 27, 2023
sundasnoreen12
force-pushed
the
sundas/INF-1184
branch
from
December 27, 2023 16:35
30812ac
to
c35f79a
Compare
sundasnoreen12
force-pushed
the
sundas/INF-1184
branch
from
December 27, 2023 16:45
c35f79a
to
c8ac33a
Compare
awais-ansari
requested changes
Jan 2, 2024
awais-ansari
approved these changes
Jan 3, 2024
ayesha-waris
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
INF-1184
Description
Stack notifications panel on top of discussions based on Legacy Notifications vs Discussions Sidebar
When a user navigates to a unit, the sidebar should open when:
Sidebar should open irrespective of whether the user has closed it on the previous unit they visited.
Screenshots