Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add eslint role for no message description #1143

Closed
wants to merge 1 commit into from
Closed

feat: add eslint role for no message description #1143

wants to merge 1 commit into from

Conversation

ghassanmas
Copy link
Member

@ghassanmas ghassanmas commented Jul 19, 2023 •
edited
Loading

This uses an eslint role for getting strings with no
descriptions, this for demonstration purpose and can be used
for checking other MFEs or JS/React base repos

Ref: openedx/wg-translations/issues/5

This PR checks should fail

@openedx-webhooks
Copy link

openedx-webhooks commented Jul 19, 2023 •
edited
Loading

Thanks for the pull request, @ghassanmas! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

This is currently a draft pull request. When it is ready for our review and all tests are green, click "Ready for Review", or remove "WIP" from the title, as appropriate.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jul 19, 2023
@ghassanmas
feat: add eslint role for no message description
6e9362c 
  This uses an eslint role for getting strings with no
  descriptions, this for demonstration purpose and can be used
  for checking other MFEs or JS/React base repos

  Ref: openedx/wg-translations/issues/5
@ghassanmas ghassanmas force-pushed the example-no-description-twg-5 branch from cd4024f to 6e9362c Compare July 19, 2023 16:24
@ghassanmas ghassanmas mentioned this pull request Jul 19, 2023
Open
@ghassanmas ghassanmas marked this pull request as draft July 19, 2023 16:30
@itsjeyd
Copy link

itsjeyd commented Jul 26, 2023

Hey there @ghassanmas, thank you for this contribution! Please let us know when it is ready for review.

@itsjeyd itsjeyd added waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. core contributor PR author is a Core Contributor (who may or may not have write access to this repo). labels Jul 26, 2023
@brian-smith-tcril
Copy link
Contributor

Thank you so much for making this example PR! I think this makes sense to have org wide, would you mind making a PR to https://github.com/openedx/frontend-build updating https://github.com/openedx/frontend-build/blob/master/.eslintrc.js?

I think a PR there would be a great place for the discussion around this to happen.

@itsjeyd
Copy link

itsjeyd commented Sep 13, 2023

Hi @ghassanmas @brian-smith-tcril, this PR hasn't seen any activity in a while so I wanted to check in and see if we should keep it open?

@itsjeyd
Copy link

itsjeyd commented Sep 26, 2023

Hi @ghassanmas, just a quick update that we're closing this PR now because it's become stale. Feel free to reopen if/when you have time to come back to this work :)

@itsjeyd itsjeyd closed this Sep 26, 2023
@openedx-webhooks
Copy link

@ghassanmas Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

1 similar comment
@openedx-webhooks
Copy link

@ghassanmas Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

@itsjeyd itsjeyd added closed inactivity PR was closed because the author abandoned it and removed waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. labels Sep 26, 2023
ghassanmas added a commit to ghassanmas/frontend-build that referenced this pull request Sep 27, 2023
@ghassanmas
feat: add eslint role for no message description
0a32690 
  This uses an eslint role for getting strings with no
  descriptions, this for demonstration purpose and can be used
  for checking other MFEs or JS/React base repos

  Ref: openedx/wg-translations/issues/5
  Related discussion: openedx/frontend-app-learning/pull/1143
@ghassanmas ghassanmas mentioned this pull request Sep 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
closed inactivity PR was closed because the author abandoned it core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U
Projects
Contributions
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ghassanmas @openedx-webhooks @itsjeyd @brian-smith-tcril