Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Editor bar visibility (quince.master) #583

Conversation

vladislavkeblysh
Copy link
Contributor

Description

  • Fixed editor bar visibility when scrolling up

Screenshot 2023-10-16 at 12 09 51
Screenshot 2023-10-16 at 12 10 13

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 16, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Oct 16, 2023

Thanks for the pull request, @vladislavkeblysh! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Oct 16, 2023
@itsjeyd
Copy link

itsjeyd commented Oct 17, 2023

@vladislavkeblysh Thank you for this contribution!

@itsjeyd itsjeyd added the backport PR backports a change from main to a named release. label Oct 17, 2023
@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (open-release/quince.master@eb127cd). Click here to learn what that means.

Additional details and impacted files
@@                      Coverage Diff                      @@
##             open-release/quince.master     #583   +/-   ##
=============================================================
  Coverage                              ?   92.43%           
=============================================================
  Files                                 ?      169           
  Lines                                 ?     3451           
  Branches                              ?      898           
=============================================================
  Hits                                  ?     3190           
  Misses                                ?      241           
  Partials                              ?       20           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mphilbrick211 mphilbrick211 added product review PR requires product review before merging and removed needs test run Author's first PR to this repository, awaiting test authorization from Axim labels Oct 17, 2023
@awais-ansari awais-ansari added the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Nov 8, 2023
@awais-ansari
Copy link
Contributor

@vladislavkeblysh breaking changes have been mentioned here.

@awais-ansari awais-ansari removed the product review PR requires product review before merging label Nov 8, 2023
@vladislavkeblysh
Copy link
Contributor Author

@awais-ansari I have seen it. I will fix it soon, thank you

@mphilbrick211 mphilbrick211 added the product review PR requires product review before merging label Nov 15, 2023
@vladislavkeblysh vladislavkeblysh force-pushed the keblysh/feat/editor-bar-quince.master branch from d110e6f to 446483e Compare November 25, 2023 13:32
@itsjeyd itsjeyd removed the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Nov 29, 2023
@arbrandes
Copy link
Contributor

Do we just need to press the merge button, now? Are all issues fixed?

@cmltaWt0
Copy link

Master PR: #582

@itsjeyd
Copy link

itsjeyd commented Dec 14, 2023

@arbrandes

Do we just need to press the merge button, now? Are all issues fixed?

There seem to be some issues left to fix on the master PR, so @vladislavkeblysh might need to update this PR and the Palm backport (#581) with some follow-up changes to get them ready for merge.

@awais-ansari awais-ansari added waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. and removed product review PR requires product review before merging labels Dec 18, 2023
@vladislavkeblysh
Copy link
Contributor Author

@awais-ansari @mphilbrick211 Fixed comment from master

Copy link
Contributor

@sundasnoreen12 sundasnoreen12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR LGTM

@awais-ansari awais-ansari merged commit 2dafb6a into openedx:open-release/quince.master Jan 3, 2024
6 checks passed
@openedx-webhooks
Copy link

@vladislavkeblysh 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@awais-ansari awais-ansari removed the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport PR backports a change from main to a named release. merged open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

8 participants