-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Enhancements to page (quince.master) #578
feat: Enhancements to page (quince.master) #578
Conversation
vladislavkeblysh
commented
Oct 12, 2023
- Fixed font family on page
- Fixed borders on action bar on mobile view
- Fixed newest first text overlap another text
- Fixed displaying user name on mobile view
Thanks for the pull request, @vladislavkeblysh! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
@vladislavkeblysh Thank you for this contribution! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## open-release/quince.master #578 +/- ##
=============================================================
Coverage ? 92.32%
=============================================================
Files ? 169
Lines ? 3451
Branches ? 899
=============================================================
Hits ? 3186
Misses ? 244
Partials ? 21 ☔ View full report in Codecov by Sentry. |
@vladislavkeblysh please resolve conflict. Some changes have been suggested here. |
Hi @vladislavkeblysh, a friendly reminder to follow up on @awais-ansari's latest comment about resolving conflicts, and to address feedback that you got from @sundasnoreen12 on the main PR for this change (#577). |
@itsjeyd I will fix it soon, thank you! |
6f0bc04
to
662afd6
Compare
@itsjeyd All comments fixed and branch updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR LGTM
Is this now just a matter of pressing the merge button? Should I do it? :) |
The master PR still in open state. |
e9e3db5
into
openedx:open-release/quince.master
@vladislavkeblysh 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |