-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for loading themes at runtime #558
Conversation
Thanks for the pull request, @xitij2000! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. This is currently a draft pull request. When it is ready for our review and all tests are green, click "Ready for Review", or remove "WIP" from the title, as appropriate. |
f10c225
to
c38d6de
Compare
cedebbc
to
ebad8af
Compare
Hey @xitij2000, just to confirm, you're planning to come back to this PR at some point, right? |
Hey @xitij2000, Just to confirm. Do you still need this PR? We are planning to clean up all open PRs. |
@xitij2000 closing this PR. Please reopen it whenever you start working on it. Thanks. |
@xitij2000 Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future. |
1 similar comment
@xitij2000 Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future. |
Description
This PR updates this repo to use the version of Paragon with design tokens, and runtime theming.
How Has This Been Tested?
To test the changes in this PR you need to set things up as follows:
npm install --legacy-peer-deps
to install the packages. This is installing current WIP versions so this allows installation despite conflicts.module.config.js
file with the following contents:Note that the 'dir' key above should point to where you've checked out
frontend-platform
to the correct version. i.e the version in pacakge.json3. If using tutor, shut down the discussion MFE and add the following content to .env.private:
And add the following to webpack.dev.config.js:
This will allow loading the MFE from apps.local.overhang.io:2002.
Screenshots/sandbox (optional):
Include a link to the sandbox for design changes or screenshot for before and after. Remove this section if it's not applicable.
Merge Checklist
Post-merge Checklist