feat!: remove Maintenance header link #1526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...by bumping frontend-component-header 5.7.0 -> 5.8.0 Our reasoning is that the two functions of the Studio Maintenance dashboard (Announcements and Maintenance Banner) have been broken for a while. It's actually version 5.7.2 that removes the link [1] but since 5.8.0 has no breaking changes, it seemed prudent to jump straight to latest. [1] https://github.com/openedx/frontend-component-header/releases/v5.7.2 Related PR: openedx/edx-platform#35852
|
The version bump didn't happen automatically, can you give this a review @feanil ? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1526 +/- ##
=======================================
Coverage 93.08% 93.08%
=======================================
Files 1051 1051
Lines 20586 20586
Branches 4459 4375 -84
=======================================
Hits 19162 19162
- Misses 1355 1357 +2
+ Partials 69 67 -2 ☔ View full report in Codecov by Sentry. |
feanil
approved these changes
Nov 22, 2024
|
It looks like this did not get automatically created because there are a backlog of ignored open renovate PRs: #632 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...by bumping frontend-component-header 5.7.0 -> 5.8.0
Our reasoning is that the two functions of the Studio Maintenance dashboard (Announcements and Maintenance Banner) have been broken for a while.
It's actually version 5.7.2 that removes the link [1] but since 5.8.0 has no breaking changes, it seemed prudent to jump straight to latest.
[1] https://github.com/openedx/frontend-component-header/releases/v5.7.2
Related PR: openedx/edx-platform#35852