Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: When I clear a filter, I am redirected to the collections tab #1524

Closed
jmakowski1123 opened this issue Nov 20, 2024 · 6 comments
Closed
Assignees
Labels
bug Report of or fix for something that isn't working as intended

Comments

@jmakowski1123
Copy link

When I clear a filter, I am automatically redirected to the Collections tab, even if my filter wasn't refining any collections. I think any clearing of filters should redirect to the Library home.

@jmakowski1123 jmakowski1123 converted this from a draft issue Nov 20, 2024
@jmakowski1123 jmakowski1123 added the bug Report of or fix for something that isn't working as intended label Nov 20, 2024
@bradenmacdonald
Copy link
Contributor

@jmakowski1123 Can you provide more details? I can't reproduce this but I do see a similar bug: when I'm on the "Components" tab and I set a "Type" filter and then clear it, it jumps to the "All Content" tab instead of staying on "Components" as I'd expect.

Filter.Reset.Bug.mov

@bradenmacdonald
Copy link
Contributor

I would generally expect that clearing of filters does not "redirect" me anywhere.

@DanielVZ96 DanielVZ96 self-assigned this Nov 22, 2024
@DanielVZ96
Copy link
Contributor

I was able to reproduce this. Turns out it comes back to the first tab that was loaded.

https://www.loom.com/share/355e907bb767476a8d50c434233bcd23?sid=5349e45e-fe07-4c1d-9d75-f2126cf3fee2

@bradenmacdonald
Copy link
Contributor

Ah, interesting. Good work figuring that out.

@ChrisChV
Copy link
Contributor

@jmakowski1123 @lizc577 @sdaitzman @marcotuts This is ready for AC testing on the sandbox

@ChrisChV ChrisChV moved this from Backlog to Ready for AC testing in Libraries Overhaul Dec 23, 2024
@jmakowski1123
Copy link
Author

This is fixed, thanks!

@github-project-automation github-project-automation bot moved this from Ready for AC testing to Done in Libraries Overhaul Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Report of or fix for something that isn't working as intended
Projects
Status: Done
Development

No branches or pull requests

4 participants