Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: plugin slots for video and file upload components and alerts #1523

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

xitij2000
Copy link
Contributor

Description

This change adds plugin slots for the file and video upload pages to allow developers to customise those components. It also adds empty slots allowing developers to add additional alerts.

Supporting information

NA

Testing instructions

TBD

Other information

This change is being made to support a feature where a client wants course authors to acknowledge fair use terms before they are allowed to upload files

@xitij2000 xitij2000 requested a review from a team as a code owner November 20, 2024 12:37
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Nov 20, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @xitij2000!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/2u-tnl. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@xitij2000 xitij2000 force-pushed the kshitij/plugin-slots/files-and-alerts branch from d1a51a4 to 694edb1 Compare November 20, 2024 12:38
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 96.24060% with 5 lines in your changes missing coverage. Please review.

Project coverage is 92.97%. Comparing base (b110b6b) to head (9c79a41).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/files-and-videos/generic/EditFileErrors.jsx 69.23% 4 Missing ⚠️
src/plugin-slots/CourseVideosSlot/index.jsx 98.64% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1523   +/-   ##
=======================================
  Coverage   92.96%   92.97%           
=======================================
  Files        1075     1079    +4     
  Lines       21190    21218   +28     
  Branches     4554     4489   -65     
=======================================
+ Hits        19700    19727   +27     
- Misses       1424     1425    +1     
  Partials       66       66           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@kaustavb12 kaustavb12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Left a minor nit. Otherwise LGTM.

  • I tested this: Tested in local
  • I read through the code

errors: errorMessages,
} = useSelector(state => state.assets);

useEffect(() => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some spacing between the different hooks would make it more readable.

@xitij2000 xitij2000 force-pushed the kshitij/plugin-slots/files-and-alerts branch from a49f0b4 to 4e9d9df Compare December 16, 2024 09:54
This change add plugin slots for the file and video upload components, and the alerts components on those pages.
@xitij2000 xitij2000 force-pushed the kshitij/plugin-slots/files-and-alerts branch from 4e9d9df to 9c79a41 Compare December 19, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Status: In Eng Review
Development

Successfully merging this pull request may close these issues.

3 participants