Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library authoring page doesn't show all components on high resolutions #1479

Closed
rpenido opened this issue Nov 7, 2024 · 5 comments
Closed

Comments

@rpenido
Copy link
Contributor

rpenido commented Nov 7, 2024

When we open the Library Page it only loads the first 20 components.
If all these components fit on the screen, the infinite scroll to load more data cannot be triggered.

infinite-scroll-bug

@rpenido rpenido moved this to In grooming in Libraries Overhaul Nov 7, 2024
@rpenido
Copy link
Contributor Author

rpenido commented Nov 7, 2024

Hi @bradenmacdonald! I found this small bug while testing another PR.
To avoid this case, do you think it's okay just to increase the first load here (i.e., 20 -> 50)?

@bradenmacdonald
Copy link
Contributor

@rpenido Interesting. I would prefer not to increase the first load, but to fix the infinite scroll detector so it detects that the last component is visible and more should be loaded. However, if that seems complicated, just loading 50 is a reasonable fix :)

@rpenido
Copy link
Contributor Author

rpenido commented Nov 7, 2024

@bradenmacdonald I did some testing, and it is easier than I anticipated. I will create a task and a PR soon.

@bradenmacdonald bradenmacdonald moved this from In grooming to In Progress in Libraries Overhaul Nov 8, 2024
@rpenido rpenido moved this from In Progress to Ready for AC testing in Libraries Overhaul Nov 18, 2024
@rpenido
Copy link
Contributor Author

rpenido commented Nov 18, 2024

@jmakowski1123 @lizc577 @sdaitzman @marcotuts This is ready for AC testing on the sandbox

@sdaitzman
Copy link

Looks good to me!

@github-project-automation github-project-automation bot moved this from Ready for AC testing to Done in Libraries Overhaul Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

4 participants