Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on edx-enterprise #692

Closed
Tracked by #90
arbrandes opened this issue Dec 8, 2022 · 2 comments
Closed
Tracked by #90

Remove dependency on edx-enterprise #692

arbrandes opened this issue Dec 8, 2022 · 2 comments
Labels
enhancement Relates to new features or improvements to existing features

Comments

@arbrandes
Copy link
Contributor

In trying to include the AuthN MFE in the Tutor release of Olive, we found that the login API used by this MFE requires edx-enterprise to be deployed and configured, so that even if DISABLE_ENTERPRISE_LOGIN is set to true in the MFE, logins cannot work without it.

It should be possible to use this MFE without the edx-enterprise requirement.

@arbrandes
Copy link
Contributor Author

@zainab-amir, can you confirm there's no way around the edx-enterprise requirement?

@arbrandes
Copy link
Contributor Author

As @zainab-amir kindly noted in the Olive Matrix, enterprise support is in fact optional, because the function pointed out in the description is wrapped by enterprise.is_enabled.

While in my previous tests the function was in fact being called - and failing - it turns out that it was a red herring. For some reason, probably related to a CSRF issue in Tutor, even though enterprise was definitely not enabled, the wrapper for some reason thought it was. After fixing the above issue, the problem went away.

Closing, with apologies for the noise.

Repository owner moved this from Backlog to Done in Build-Test-Release Working Group Dec 9, 2022
Repository owner moved this from Backlog to In progress in Frontend Working Group Dec 9, 2022
@arbrandes arbrandes moved this from In progress to Closed in Frontend Working Group Dec 9, 2022
@arbrandes arbrandes removed this from the Palm.1 milestone Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Relates to new features or improvements to existing features
Projects
Status: Closed
Development

No branches or pull requests

1 participant