Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow to use any configured engine to replay tracking logs #362

Merged
merged 2 commits into from
Mar 22, 2024

Conversation

Ian2012
Copy link
Contributor

@Ian2012 Ian2012 commented Oct 27, 2023

Description: This PR uses the already configured backends to replay tracking logs

Merge checklist:

  • All reviewers approved
  • CI build is green
  • Version bumped
  • Changelog record added
  • Documentation updated (not only docstrings)
  • Commits are squashed

Post merge:

  • Create a tag
  • Check new version is pushed to PyPI after tag-triggered build is
    finished.

Author concerns: List any concerns about this PR - inelegant
solutions, hacks, quick-and-dirty implementations, concerns about
migrations, etc.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 27, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Oct 27, 2023

Thanks for the pull request, @Ian2012! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@Ian2012 Ian2012 force-pushed the cag/add-consumer-for-tracking-logs branch from 5fd42a5 to 3e724fd Compare December 4, 2023 21:29
@Ian2012 Ian2012 force-pushed the cag/add-consumer-for-tracking-logs branch 5 times, most recently from cb0476d to 14df49d Compare February 2, 2024 19:22
@Ian2012 Ian2012 force-pushed the cag/add-consumer-for-tracking-logs branch 6 times, most recently from 3a21781 to 9d5e704 Compare February 16, 2024 21:00
Base automatically changed from cag/add-consumer-for-tracking-logs to master February 19, 2024 16:32
@mphilbrick211
Copy link

Hi @Ian2012! Just checking in to see if this PR is still in progress?

@Ian2012
Copy link
Contributor Author

Ian2012 commented Mar 20, 2024

@mphilbrick211 Yes, once this PR is merged #388 I will take care of updating this PR.

@Ian2012 Ian2012 force-pushed the cag/backfill-command-test branch 2 times, most recently from a0bde69 to 19cfc78 Compare March 22, 2024 19:17
@Ian2012 Ian2012 marked this pull request as ready for review March 22, 2024 19:22
@Ian2012 Ian2012 force-pushed the cag/backfill-command-test branch 2 times, most recently from bd3fc1f to 7e4e263 Compare March 22, 2024 19:42
@Ian2012 Ian2012 force-pushed the cag/backfill-command-test branch from 7e4e263 to e60215a Compare March 22, 2024 19:46
@Ian2012 Ian2012 requested a review from bmtcril March 22, 2024 19:57
Copy link
Contributor

@bmtcril bmtcril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I've been meaning to get back to that for a while. Thanks for knocking it out

@Ian2012 Ian2012 merged commit ac59cec into master Mar 22, 2024
10 checks passed
@Ian2012 Ian2012 deleted the cag/backfill-command-test branch March 22, 2024 20:19
@openedx-webhooks
Copy link

@Ian2012 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants