-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: pypi-publish master branch sunset #152
Conversation
Thanks for the pull request, @CodeWithEmad! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently unmaintained. To get help with finding a technical reviewer, tag the community contributions project manager for this PR in a comment and let them know that your changes are ready for review:
Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Sorry to ping you here, @feanil but there's no CI jobs are failing, but my change didn't cause it. Probably a dependency version mismatch? |
@CodeWithEmad yea, there was a deeper issue that I found while I did some other maintenance. I'm not sure how that got merged as is but once the maintenance PR above lands, you should be able to rebase this and tests should pass. |
As it mentioned in the gh-action-pypi-publish repo, the master branch version has been sunset and we should use release/v1.
08452b5
to
b48d1fb
Compare
@CodeWithEmad 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
This will fix the warning of 'The master branch version has been sunset for gh-action-pypi-publisher'