Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Add node 20 to the test matrix. #34998

Merged
merged 2 commits into from
Jun 20, 2024
Merged

Conversation

feanil
Copy link
Contributor

@feanil feanil commented Jun 14, 2024

No description provided.

@feanil feanil marked this pull request as ready for review June 18, 2024 13:55
@feanil feanil force-pushed the feanil/test_with_node_20 branch from f2080cc to 4ca4a58 Compare June 18, 2024 13:57
Copy link
Member

@kdmccormick kdmccormick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So it... just works?! Nice!

.github/workflows/quality-checks.yml Outdated Show resolved Hide resolved
@feanil
Copy link
Contributor Author

feanil commented Jun 18, 2024

An open question that I forgot to post earlier is, when should we update docs/.nvmrc should I do that as a part of this PR or should that be when we call this official and start the 6-month timer? If the tests are passing, is that all just now?

@feanil feanil merged commit e4c7280 into master Jun 20, 2024
48 checks passed
@feanil feanil deleted the feanil/test_with_node_20 branch June 20, 2024 13:26
@feanil
Copy link
Contributor Author

feanil commented Jun 20, 2024

The .nvmrc sholud be updated as a part of dropping support for Node 18 in 6-months. In the meantime, we should create a DEPR ticket.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants