feat: remove the broken Zooming Image Tool #31435
Conversation
|
@ormsbee, do you happen to have some context on this to give it a once-over? Any idea who I should tag on the 2U side? |
|
This probably deserves a DEPR, even if it's broken (so that we have the justification somewhere). @dianakhuang, @feanil: In the case where something has been broken for a really long time, is DEPR notice + immediate removal the right thing to do? FYI @mondiaz |
|
@ormsbee Agreed, it would be good to have have a depr but you can mark it as immediately accepted in this case since we've accepted it being broken for such a long time. |
There was a problem hiding this comment.
@arbrandes Do you think you can get this PR over the line for Redwood? Seems worthwhile to finish it up.
feanil
added
depr
arbrandes
force-pushed
the
remove-zooming-image
branch
from
f0f50d7 to
4b2974d
Compare
The Zooming Image Tool does not load properly, currently, and even if it did, relying on an external Javascript to function across releases is not something we can support. Thus, we remove it from the list of HTML block templates until such time as a more robust solution is found.
arbrandes
force-pushed
the
remove-zooming-image
branch
from
4b2974d to
4b700ba
Compare
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
Description
The Zooming Image Tool does not currently work, and the security implications of getting such external Javascript to function properly are unclear at best. We should simply remove it from the list of HTML block templates.
Supporting information
The failure was discovered as part of release testing for Olive undertaken by the Build-Test-Release working group.
Testing instructions
To test, simply note that the Zooming Image Tool is no longer given as an option when instantiating a new Text block in Studio.
Deadline
Palm