Fix optimizing of draggabilly and json2

[andy-armstrong]

Proposed fix for the release candidate for https://openedx.atlassian.net/browse/TNL-3766

I've kicked off a sandbox build so I'll see how that looks in the morning:

https://andy-armstrong.sandbox.edx.org

FYI: @cahrens @jcdyer

[andy-armstrong]

Reviewers: this is the key problem which is that the Draggabilly vendor file doesn't correctly define its own module when using RequireJS. This fix allows the file to be bundled by RequireJS Optimizer.

[cahrens]

Please add a comment to the code explaining why this is needed and that it is specifically for Studio (since LMS uses a namespaced version).

[andy-armstrong]

Done

[andy-armstrong]

@cahrens I have no idea what is going on, but I can't log in to Studio on my sandbox. I can't see how my changes could have caused this, although I suppose they must have. There are no errors in the browser, and no errors shown in the cms log file.

[andy-armstrong]

I updated my sandbox to the RC branch and am having the same trouble, so it isn't my change. I've kicked off a clean sandbox build in case something went wrong with the last one.

[andy-armstrong]

At @cahrens's suggestion, I've removed the JSON2 shim from Studio as it is not needed. The JSON2 library is only used for older browsers, none of which we support.

[andy-armstrong]

@cahrens @dianakhuang Please review this fix for this week's release.

[andy-armstrong]

FYI you can see a video rendering successfully in Studio on my sandbox:

https://studio-andy-armstrong.sandbox.edx.org/container/block-v1:edX+DemoX+Demo_Course+type@vertical+block@vertical_0270f6de40fc

[cahrens]

👍

[dianakhuang]

👍 yay for getting rid of things we don't need.

[andy-armstrong]

jenkins run python

[andy-armstrong]

jenkins run lettuce

[andy-armstrong]

jenkins run bokchoy

[andy-armstrong]

jenkins run lettuce

[andy-armstrong]

jenkins run lettuce

[andy-armstrong]

jenkins run lettuce