-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Programs: added platform support package and configuration model. #10350
Conversation
085bfbd
to
05bc0e0
Compare
@cpennington The new configuration model should be used instead of django settings for Programs API settings, and |
05bc0e0
to
1bb2928
Compare
jenkins run python |
Indicate whether LMS dashboard functionality related to Programs should | ||
be enabled or not. | ||
""" | ||
return self.enabled and self.enable_student_dashboard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why keep these separate?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The way I understand config models, enabled
is a sort of master on/off switch. The dashboard-specific toggle is meant to be a kill switch specifically for the learner dashboard. My thinking is that when we roll out Studio integration for example, we may benefit from having individual kill switches for each integration point.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense, thanks.
👍 |
@feanil please review - as discussed in person, this is the working plan for configuring programs IDA URLs in lms/cms, as opposed to using ansible/django settings. |
👍 |
from openedx.core.djangoapps.programs.models import ProgramsApiConfig | ||
|
||
|
||
class ProgramsApiConfigAdmin(ConfigurationModelAdmin): # pylint: disable=missing-docstring |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we add search to this if we need to find people it will make our lives easier.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
discussed offline - this refers to a separate (future ticket) and n/a here
👍 |
Programs: added platform support package and configuration model.
ECOM-2657