Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Programs: added platform support package and configuration model. #10350

Merged
merged 1 commit into from
Oct 27, 2015

Conversation

jimabramson
Copy link

ECOM-2657

@jimabramson jimabramson force-pushed the jsa/ecom-2657 branch 3 times, most recently from 085bfbd to 05bc0e0 Compare October 25, 2015 04:49
@jimabramson
Copy link
Author

@cpennington
@rlucioni
@zubair-arbi this will overlap with your work in progress on ECOM-2578. Because this contains a django model and admin, the right location for this package is openedx.core.djangoapps (not lib).

The new configuration model should be used instead of django settings for Programs API settings, and is_student_dashboard_enabled should be used as the toggle to enable/disable xseries upsell + presentation on the student dashboard.

@jimabramson
Copy link
Author

jenkins run python

Indicate whether LMS dashboard functionality related to Programs should
be enabled or not.
"""
return self.enabled and self.enable_student_dashboard
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why keep these separate?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The way I understand config models, enabled is a sort of master on/off switch. The dashboard-specific toggle is meant to be a kill switch specifically for the learner dashboard. My thinking is that when we roll out Studio integration for example, we may benefit from having individual kill switches for each integration point.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks.

@rlucioni
Copy link
Contributor

👍

@jimabramson
Copy link
Author

@feanil please review - as discussed in person, this is the working plan for configuring programs IDA URLs in lms/cms, as opposed to using ansible/django settings.

@cpennington
Copy link
Contributor

👍

from openedx.core.djangoapps.programs.models import ProgramsApiConfig


class ProgramsApiConfigAdmin(ConfigurationModelAdmin): # pylint: disable=missing-docstring
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add search to this if we need to find people it will make our lives easier.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

discussed offline - this refers to a separate (future ticket) and n/a here

@feanil
Copy link
Contributor

feanil commented Oct 27, 2015

👍

jimabramson pushed a commit that referenced this pull request Oct 27, 2015
Programs: added platform support package and configuration model.
@jimabramson jimabramson merged commit edf09d8 into master Oct 27, 2015
@jimabramson jimabramson deleted the jsa/ecom-2657 branch October 27, 2015 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants