Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEPR]: IDVerificationService.get_verification_details_by_id and IDVerificationSupportView #35452

Open
1 of 3 tasks
MichaelRoytman opened this issue Sep 9, 2024 · 3 comments
Assignees
Labels
depr Proposal for deprecation & removal per OEP-21

Comments

@MichaelRoytman
Copy link
Contributor

MichaelRoytman commented Sep 9, 2024

Proposal Date

2024-09-09

Target Ticket Acceptance Date

2024-09-27

Earliest Open edX Named Release Without This Functionality

Sumac - 2024-10

Rationale

The get_verification_details_by_id method of the IDVerificationService is used to get information about an IDV attempt, given an ID.

This method is solely used by the IDVerificationSupportView, which is used by the VerifiedName component of the frontend-app-support-tools MFE to fetch and display the status of an IDV attempt associated with a verified name. A screenshot is included below.

image

With the introduction of the generic, vendor-agnostic [VerificationAttempt](https://github.com/openedx/edx-platform/blob/master/lms/djangoapps/verify_student/models.py#L1195) model to the [verify_student](https://github.com/openedx/edx-platform/tree/master/lms/djangoapps/verify_student) application, this service method poses a problem. The idsupported byget_verification_details_by_id` must be an ID of the classes that inherit from the IdVerificationAttempt abstract base class, so the VerificationAttempt model cannot be properly integrated into this method.

We are in the process of refactoring the edx-name-affirmation application and the frontend-app-support-tools MFE to remove the use of the IDVerificationSupportView.

The first stage of this is complete and can be viewed in this pull request: edx/edx-name-affirmation#215

We propose the removal of the get_verification_details_by_id method of the IDVerificationService and the IDVerificationSupportView that uses it.

Removal

The following is being removed.

Replacement

There will be no replacement.

Deprecation

This code will not be marked for deprecation.

Migration

No automated migration will be needed.

Additional Info

This deprecation is required by the IDV extensibility project, documented in this platform-roadmap ticket: openedx/platform-roadmap#367.

You can find the Discourse thread here.

Task List

@MichaelRoytman
Copy link
Contributor Author

This DEPR has been communicated. A Discourse thread has been started here. The DEPR has been posted to the #general and #open-edx-proposals Slack channels in the Open edX Slack instance.

We are providing two weeks of review time before marking this DEPR approved. If no feedback is provided, this code will be removed sometime in late September or early-to-mid October.

@alangsto alangsto moved this from Communicated to Accepted in DEPR: Deprecation & Removal Sep 27, 2024
@alangsto alangsto moved this from Accepted to Removing in DEPR: Deprecation & Removal Sep 27, 2024
@alangsto
Copy link
Contributor

In the process of removing the code now.

@alangsto
Copy link
Contributor

Code has been removed as part of #35560

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
depr Proposal for deprecation & removal per OEP-21
Projects
Status: Removed
Development

No branches or pull requests

2 participants