build: Don't fail the build if DockerHub login fails (#36100)

This iterates on #36089, which logged us into DockerHub during unit tests in order to reduce how often DockerHub rate-limits us. Forks will fail to log into DockerHub unless the fork owner configures their own DockerHub creds. This PR is an attempt to make it so that unit tests don't fail when DockerHub login fails.
openedx · Jan 10, 2025 · 290209b · 290209b
1 parent e6ddd9c
commit 290209b
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/.github/workflows/unit-tests.yml b/.github/workflows/unit-tests.yml
@@ -73,8 +73,12 @@ jobs:
         run: |
           sudo apt-get update && sudo apt-get install libmysqlclient-dev libxmlsec1-dev lynx
 
-      - name: Login to Docker Hub
+      # Try to log into DockerHub so that we're less likely to be rate-limited when pulling certain images.
+      # This will fail on any edx-platform fork which doesn't explicitly define its own DockerHub creds.
+      # That's OK--if we fail to log in, we'll proceed anonymously, and hope we don't get rate-limited.
+      - name: Try to log into Docker Hub
         uses: docker/[email protected]
+        continue-on-error: true
         with:
           username: ${{ secrets.DOCKERHUB_USERNAME }}
           password: ${{ secrets.DOCKERHUB_PASSWORD }}