-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleanup for howtos3 #638
base: main
Are you sure you want to change the base?
cleanup for howtos3 #638
Conversation
cleaning up drag_and_drop_deprecated.rst doc
Thanks for the pull request, @jesgreco! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Let's stop committing to this branch as it's getting big. Focus on fixing the build errors, please! |
@sarina errors were fixed, you can proceed to merge this PR. Thanks! |
source/educators/how-tos/communication/administer_discussions.rst
Outdated
Show resolved
Hide resolved
source/educators/how-tos/course_development/exercise_tools/add_numerical_input_problem.rst
Outdated
Show resolved
Hide resolved
@@ -87,10 +87,9 @@ who enroll in the new course run. | |||
|
|||
.. only:: Partners |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, delete everything under .. only:: Partners
, please.
Can you please check the other files in this pull request to see if they have anything specified as .. only:: Partners
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done! I've reviewed the 27 files and no further reference for that.
@@ -96,7 +96,6 @@ Drag and Drop Problem | |||
:maxdepth: 2 | |||
:glob: | |||
|
|||
../references/course_development/exercise_tools/drag_and_drop.rst |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you want to keep this in, and delete L104 (the name of the file you deleted)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jesgreco did you read this comment? it's how you fix the build.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but still the error is happening.
@sarina you can proceed to the merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My comments are addressed, but I asked @jswope00 to review this PR as well. John can merge once his review is completed. (John, I suggest you "squash and merge" so we don't have a really long commit history)
ok, @sarina - I've added one more file since one of it was deleted (the deprecated one). |
cleaning up drag_and_drop_deprecated.rst doc