Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup for howtos3 #638

Open
wants to merge 40 commits into
base: main
Choose a base branch
from

Conversation

jesgreco
Copy link
Contributor

@jesgreco jesgreco commented Dec 6, 2024

cleaning up drag_and_drop_deprecated.rst doc

cleaning up drag_and_drop_deprecated.rst doc
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Dec 6, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @jesgreco!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/docs-openedx-org-maintainers. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@jesgreco
Copy link
Contributor Author

jesgreco commented Dec 6, 2024

This document seems to be deprecated so, I'm not sure if we need to include them or not @sarina @jswope00

@mphilbrick211 mphilbrick211 added the FC Relates to an Axim Funded Contribution project label Dec 9, 2024
@sarina
Copy link
Contributor

sarina commented Dec 10, 2024

Let's stop committing to this branch as it's getting big. Focus on fixing the build errors, please!

@jesgreco
Copy link
Contributor Author

@sarina errors were fixed, you can proceed to merge this PR. Thanks!

source/educators/how-tos/data/course_answers.rst Outdated Show resolved Hide resolved
source/educators/how-tos/data/manage_course_grades.rst Outdated Show resolved Hide resolved
source/educators/how-tos/drag_and_drop_deprecated.rst Outdated Show resolved Hide resolved
source/educators/how-tos/update_rerun_course.rst Outdated Show resolved Hide resolved
source/educators/how-tos/update_rerun_course.rst Outdated Show resolved Hide resolved
source/educators/how-tos/update_rerun_course.rst Outdated Show resolved Hide resolved
@@ -87,10 +87,9 @@ who enroll in the new course run.

.. only:: Partners
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, delete everything under .. only:: Partners, please.

Can you please check the other files in this pull request to see if they have anything specified as .. only:: Partners?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done! I've reviewed the 27 files and no further reference for that.

@@ -96,7 +96,6 @@ Drag and Drop Problem
:maxdepth: 2
:glob:

../references/course_development/exercise_tools/drag_and_drop.rst
Copy link
Contributor

@sarina sarina Dec 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you want to keep this in, and delete L104 (the name of the file you deleted)

Copy link
Contributor

@sarina sarina Dec 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jesgreco did you read this comment? it's how you fix the build.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but still the error is happening.

@jesgreco
Copy link
Contributor Author

@sarina you can proceed to the merge.

@jesgreco jesgreco closed this Dec 13, 2024
@jesgreco jesgreco reopened this Dec 13, 2024
Copy link
Contributor

@sarina sarina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My comments are addressed, but I asked @jswope00 to review this PR as well. John can merge once his review is completed. (John, I suggest you "squash and merge" so we don't have a really long commit history)

@jesgreco
Copy link
Contributor Author

ok, @sarina - I've added one more file since one of it was deleted (the deprecated one).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FC Relates to an Axim Funded Contribution project open-source-contribution PR author is not from Axim or 2U
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants