Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Django 4.2 updates #135

Merged
merged 4 commits into from
Jul 12, 2023
Merged

Conversation

salman2013
Copy link
Contributor

@salman2013 salman2013 commented Jun 13, 2023

Description:

  • Add support for Django 4.2

Codemod used to upgrade this repo: https://github.com/adamchainz/django-upgrade

Ticket: edx/upgrades#124

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jun 13, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Jun 13, 2023

Thanks for the pull request, @salman2013! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

⚠️ We can't start reviewing your pull request until you've submitted a signed contributor agreement or indicated your institutional affiliation. Please see the CONTRIBUTING file for more information. If you've signed an agreement in the past, you may need to re-sign. See The New Home of the Open edX Codebase for details.

Once you've signed the CLA, please allow 1 business day for it to be processed. After this time, you can re-run the CLA check by editing the PR title. If the problem persists, you can tag the @openedx/cla-problems team in a comment on your PR for further assistance.

@salman2013 salman2013 marked this pull request as ready for review June 13, 2023 10:18
@awais786 awais786 closed this Jun 13, 2023
@awais786 awais786 removed the open-source-contribution PR author is not from Axim or 2U label Jun 14, 2023
@awais786 awais786 reopened this Jun 14, 2023
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jun 14, 2023
@salman2013 salman2013 requested a review from awais786 June 27, 2023 05:29
@salman2013 salman2013 closed this Jul 3, 2023
@salman2013 salman2013 reopened this Jul 3, 2023
example/example/settings.py Outdated Show resolved Hide resolved
tox.ini Outdated Show resolved Hide resolved
Copy link
Member

@UsamaSadiq UsamaSadiq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also update PR description before merging.

@salman2013 salman2013 merged commit 466a46b into master Jul 12, 2023
@salman2013 salman2013 deleted the salman/django-pyfs/django-4.2-support branch July 12, 2023 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants