Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: using new version of i18. #2221

Merged
merged 3 commits into from
Oct 6, 2023
Merged

chore: using new version of i18. #2221

merged 3 commits into from
Oct 6, 2023

Conversation

awais786
Copy link
Contributor

@awais786 awais786 commented Oct 5, 2023

Upgrading to edx-i18n-tools==1.3.0

@@ -96,7 +96,7 @@ format: ## format code
black .

format_check: ## check that code is formatted correctly
black --check .
black --check credentials/
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure its ideal way

@awais786 awais786 marked this pull request as ready for review October 6, 2023 06:40
Copy link

@zubairshakoorarbisoft zubairshakoorarbisoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@awais786 awais786 merged commit b88eb3a into master Oct 6, 2023
9 checks passed
@awais786 awais786 deleted the check-trans branch October 6, 2023 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants