-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Django 4.2]: Django 4.2 Upgrade #2196
Conversation
6f9070a
to
b0fe735
Compare
@@ -226,6 +226,9 @@ | |||
TIME_ZONE = "UTC" | |||
TIME_ZONE_CLASS = timezone.utc | |||
|
|||
# https://docs.djangoproject.com/en/4.2/releases/4.0/#zoneinfo-default-timezone-implementation | |||
USE_DEPRECATED_PYTZ = True |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Django switched from the pytz
third-party python package to the Python native package zoneinfo
in Django 4.0. In release notes, they have mentioned that both are not equivalent so one might need some manual work for this migration. So Django provided this USE_DEPRECATED_PYTZ
setting, so we can decouple this migration from the Django upgrade.
More info: https://docs.djangoproject.com/en/4.2/releases/4.0/#zoneinfo-default-timezone-implementation
@@ -234,8 +237,6 @@ | |||
|
|||
LOCALE_PATHS = (root("conf", "locale"),) | |||
|
|||
DEFAULT_HASHING_ALGORITHM = "sha1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Django4.2 has dropped sha1
support. For details https://github.com/orgs/edx/projects/12/views/8?pane=issue&itemId=39005351
Its side effect it might logout the users from credentials
.
8d9ebd1
to
ab5149a
Compare
#2221 We are blocked due to translations check but this Temp PR is green using the fix hash. Hopefully we will get new version so i will update that in this PR. |
# via | ||
# -r requirements/base.txt | ||
# python3-openid | ||
# social-auth-core | ||
didkit==0.3.2 | ||
# via -r requirements/base.txt | ||
django==3.2.21 | ||
django==4.2.6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upgrading to 4.2.6
Upgrading to django42 and dropped django32 support.
verified stage and prod are using mysql8.
make migrations executed
Removed django32 from tox and gha.
Owning team will test and merge
feat!: Django 4.0 and above, CSRF_TRUSTED_ORIGINS must include schemes #2208 ( merge this )
Resolves Django 4.2 Upgrade #2096