Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Django 4.2 Upgrade #2096

Closed
2 of 8 tasks
UsamaSadiq opened this issue Jul 25, 2023 · 2 comments · Fixed by #2196
Closed
2 of 8 tasks

Django 4.2 Upgrade #2096

UsamaSadiq opened this issue Jul 25, 2023 · 2 comments · Fixed by #2196
Assignees
@irtazaakram
Labels
arbi-bom Assigned to tech-arbi-bom team blocked by other work PR cannot be finished until other work is complete blocked-mysql django 4.2

Comments

@UsamaSadiq
Copy link
Member

UsamaSadiq commented Jul 25, 2023 •
edited
Loading

Description

Under the effort of Django 4.2 Upgrade, complete all of the following steps to complete the upgrade.

  • Update tox & Github action workflow using modernisers to add support for Django 4.2
  • Remove any versions of Python earlier than 3.8 from tox.ini, and GitHub Actions workflows.
  • Update the pinned Django version in the requirements to Django==4.2
  • Run make upgrade to update all dependencies for Django 4.2.
  • Run and verify all tests are passing in the CI for both Django 4.2 and Django 3.2 to contain backward compatibility.
  • Run available code-mods to fix the failing tests.
  • Add conditional checks wherever needed to still have support for Django 3.2.
  • Update the repo support field in the IDA Upgrade Sheet.
@UsamaSadiq UsamaSadiq added django 4.2 arbi-bom Assigned to tech-arbi-bom team labels Jul 25, 2023
@UsamaSadiq UsamaSadiq moved this to Todo in Maintenance Jul 25, 2023
@iamsobanjaved iamsobanjaved moved this to Blocked in Arbi-BOM Aug 25, 2023
@UsamaSadiq
Copy link
Member Author

Created first PR to add Django 4.2 support in the repo #2142

@UsamaSadiq UsamaSadiq moved this from Todo to In Progress in Maintenance Sep 4, 2023
@irtazaakram irtazaakram self-assigned this Sep 20, 2023
@irtazaakram irtazaakram mentioned this issue Sep 20, 2023
Merged
5 tasks
@irtazaakram
Copy link
Member

edx-i18n-tools v1.1.0 is required for Django 4.2 support but it creates some changes in translation files which then causes validation to fail. Failure
This is a blocker for credentials

@irtazaakram irtazaakram added the blocked by other work PR cannot be finished until other work is complete label Sep 21, 2023
@iamsobanjaved iamsobanjaved moved this from Blocked to Todo in Arbi-BOM Sep 22, 2023
@iamsobanjaved iamsobanjaved moved this from In Progress to Owner Review in Maintenance Oct 5, 2023
@github-project-automation github-project-automation bot moved this from Owner Review to Done in Maintenance Oct 6, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in Arbi-BOM Oct 6, 2023
@jristau1984 jristau1984 moved this from Done to Done - Long Term Storage in Arbi-BOM Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@irtazaakram irtazaakram

Labels
arbi-bom Assigned to tech-arbi-bom team blocked by other work PR cannot be finished until other work is complete blocked-mysql django 4.2
Projects
Aperture-Maintained
Status: Done
Maintenance
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Django 4.2]: Django 4.2 Upgrade openedx/credentials
3 participants
@UsamaSadiq @irtazaakram @iamsobanjaved