feat: Application is dockerized #228
Conversation
|
Thanks for the pull request, @myhailo-chernyshov-rg! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently unmaintained. To get help with finding a technical reviewer, tag the community contributions project manager for this PR in a comment and let them know that your changes are ready for review:
Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
openedx-webhooks
added
the
open-source-contribution
mphilbrick211
added
needs test run
|
@ormsbee - are you able to review / merge this? |
| @@ -41,7 +27,7 @@ def get_version(*file_paths): | |||
| ], | |||
| description=("Command line tool, that converts Common Cartridge " "courses to Open edX Studio imports."), | |||
| entry_points={"console_scripts": ["cc2olx=cc2olx.main:main"]}, | |||
| install_requires=["lxml"], | |||
| install_requires=load_requirements("requirements/base.txt"), | |||
There was a problem hiding this comment.
Shouldn't this be reading the base.in file and not the pinned base.txt file?
There was a problem hiding this comment.
I think, using base.in can cause unpredictable behaviour because not tested package versions can be used that can become a reason of conflicts. If we populate constraints.txt, it will be completely ignored and undesirable package versions will be installed. Am I wrong?
utils.py
Outdated
| # Skip blank lines, comments, and editable installs | ||
| return not ( | ||
| line == '' | ||
| or line.startswith('-r') | ||
| or line.startswith('#') | ||
| or line.startswith('-e') | ||
| or line.startswith('git+') | ||
| or line.startswith('-c') | ||
| ) |
There was a problem hiding this comment.
startswith can take a tuple as an argument, so you can do:
return line and not line.startswith(('-r', '#', '-e', 'git+', '-c'))
myhailo-chernyshov-rg
force-pushed
the
myhailochernyshov/application-is-dockerized
branch
from
6e5509e to
80ed18c
Compare
Description
This PR is addressed to make the converter platform-independent.
To perform it, Dockerfile is written, the files that should not be included into Docker image are specified in
.dockerignore.All base requirements are installed during application installation.
Usage instructions
It will convert Common Cartridge dump from /input/file/path/cc_course_dump.imscc and save the OLX in /output/file/path/output_dir/edx_dump.zip file.
Deadline
"None"